From owner-freebsd-ports@FreeBSD.ORG Sat Mar 12 15:56:30 2011 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0D99106566B for ; Sat, 12 Mar 2011 15:56:30 +0000 (UTC) (envelope-from timur@bat.ru) Received: from mail-yw0-f54.google.com (mail-yw0-f54.google.com [209.85.213.54]) by mx1.freebsd.org (Postfix) with ESMTP id B9DE08FC0A for ; Sat, 12 Mar 2011 15:56:30 +0000 (UTC) Received: by ywf9 with SMTP id 9so1749580ywf.13 for ; Sat, 12 Mar 2011 07:56:29 -0800 (PST) Received: by 10.146.164.11 with SMTP id m11mr15433095yae.20.1299943547276; Sat, 12 Mar 2011 07:25:47 -0800 (PST) MIME-Version: 1.0 Sender: timur@bat.ru Received: by 10.147.171.19 with HTTP; Sat, 12 Mar 2011 07:25:27 -0800 (PST) In-Reply-To: References: From: "Timur I. Bakeyev" Date: Sat, 12 Mar 2011 16:25:27 +0100 X-Google-Sender-Auth: WZU18a0uG9qlRKYlXU32XGGAhKo Message-ID: To: jhell Content-Type: text/plain; charset=ISO-8859-1 Cc: ports@freebsd.org Subject: Re: net/samba-libsmbclient SAMBA_PORT= -> SAMBA_PORT?= X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Mar 2011 15:56:31 -0000 Hi! On Tue, Mar 1, 2011 at 6:46 AM, jhell wrote: > Could you please change the SAMBA_PORT= directive in samba-libsmbclient to > SAMBA_PORT?= samba34 so it can be overridden by make.conf or command line ? No, I believe it's a bad idea. > There is probably some bad magic that will happen on a machine with samba35 > installed and libsmbclient34 and I would like to stay as close as I can to > using the same version of samba that's installed and making the above > corrections would still allow for the current functionality to be kept while > allowing an override. The flexibility in the base port definition is done to ease my life, as a maintainer, not to easily switch between the versions. Code wise libsmbclient in 34 and 35 should be the same, as the library isn't actively developed and stable. I don't want people to recompile firefox, for example, cause version of Samba have been bumped again - there is no real need for this. Another story is that it's hard to guaranty that that between 34, 35 and 36 version the packaging list of the port will remain the same. > > Specifically I would like to stay away from having to edit anything in the > ports structure Makefiles as those changes would not be static across port > snaps. > Regards, Timur.