From owner-svn-src-head@FreeBSD.ORG Tue Nov 22 20:41:56 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77CC31065675; Tue, 22 Nov 2011 20:41:56 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay04.stack.nl [IPv6:2001:610:1108:5010::107]) by mx1.freebsd.org (Postfix) with ESMTP id 16D838FC13; Tue, 22 Nov 2011 20:41:56 +0000 (UTC) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id 6CB7B1DD6DF; Tue, 22 Nov 2011 21:41:55 +0100 (CET) Received: by snail.stack.nl (Postfix, from userid 1677) id 488BC28468; Tue, 22 Nov 2011 21:41:55 +0100 (CET) Date: Tue, 22 Nov 2011 21:41:55 +0100 From: Jilles Tjoelker To: Dag-Erling Smorgrav Message-ID: <20111122204154.GA14090@stack.nl> References: <201111211640.pALGedXg051270@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201111211640.pALGedXg051270@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r227798 - in head: . lib/libpam lib/libpam/modules X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2011 20:41:56 -0000 On Mon, Nov 21, 2011 at 04:40:39PM +0000, Dag-Erling Smorgrav wrote: > Author: des > Date: Mon Nov 21 16:40:39 2011 > New Revision: 227798 > URL: http://svn.freebsd.org/changeset/base/227798 > Log: > Simplify the libpam build by removing the shared modules' dependency > on the shared library. The modules are loaded by the library, so we > know it'll be there when we need it. Although this will work, I think it trades the quality of the binaries for a cleaner build system. It is better to pass all libraries to ld(1) even though a .so may have unresolved references: the NEEDED entry serves as an additional protection against version mismatches and symbol versioning (if you ever add it) requires ld(1) to have access to the .so containing the definition so it knows the version name to store in the output file. -- Jilles Tjoelker