From owner-freebsd-net@freebsd.org Thu Nov 5 00:41:02 2020 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E9AAD46A6AF for ; Thu, 5 Nov 2020 00:41:02 +0000 (UTC) (envelope-from mike@sentex.net) Received: from pyroxene2a.sentex.ca (pyroxene19.sentex.ca [IPv6:2607:f3e0:0:3::19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "pyroxene.sentex.ca", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CRPp608dDz4Tpf for ; Thu, 5 Nov 2020 00:41:02 +0000 (UTC) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4:50ea:91d2:5f62:c855] ([IPv6:2607:f3e0:0:4:50ea:91d2:5f62:c855]) by pyroxene2a.sentex.ca (8.15.2/8.15.2) with ESMTPS id 0A50exjJ081760 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Wed, 4 Nov 2020 19:41:00 -0500 (EST) (envelope-from mike@sentex.net) Subject: Re: remote use-after-free in icmp6 To: "Alexander V. Chernikov" , Maxime Villard , "freebsd-net@freebsd.org" References: <0d6f3bc8-d727-892b-be8e-947c9dfddc24@m00nbsd.net> <5142321603916685@mail.yandex.ru> <3581301603916797@mail.yandex.ru> From: mike tancsa Message-ID: Date: Wed, 4 Nov 2020 19:41:01 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <3581301603916797@mail.yandex.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4CRPp608dDz4Tpf X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mike@sentex.net designates 2607:f3e0:0:3::19 as permitted sender) smtp.mailfrom=mike@sentex.net X-Spamd-Result: default: False [-1.38 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[mike]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HFILTER_HELO_IP_A(1.00)[pyroxene2a.sentex.ca]; HFILTER_HELO_NORES_A_OR_MX(0.30)[pyroxene2a.sentex.ca]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM_LONG(-1.05)[-1.049]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f3e0::/32]; NEURAL_HAM_SHORT(-0.34)[-0.341]; DMARC_NA(0.00)[sentex.net]; NEURAL_HAM_MEDIUM(-0.99)[-0.986]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:11647, ipnet:2607:f3e0::/32, country:CA]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-net] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2020 00:41:03 -0000 Hi,     Is this an issue in HEAD only ? Or is it something that needs to be MFC'd ?     ---Mike On 10/28/2020 4:27 PM, Alexander V. Chernikov wrote: > 28.10.2020, 20:25, "Alexander V. Chernikov" : >> 28.10.2020, 18:34, "Maxime Villard" : >>> In icmp6_notify_error(), 'finaldst' points to data within an mbuf, but when >>> iterating over the next IPv6 options the kernel can free that mbuf, meaning >>> the dereferences of 'finaldst' hit a freed buffer. > [sorry for reposting, plaintext this time] >> Fixed in r367114, thanks for reporting! >>> Note that this is triggerable without specific conditions, over just ICMPv6. >>> >>> Maxime >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >