Date: Sat, 14 Jul 2001 13:22:53 -0700 (PDT) From: Matthew Jacob <mjacob@feral.com> To: Alfred Perlstein <bright@sneakerz.org> Cc: <smp@freebsd.org>, <audit@freebsd.org> Subject: Re: planned change to mbinit code and minor changes to mp startup Message-ID: <20010714132021.G29314-100000@wonky.feral.com> In-Reply-To: <20010714151902.A15299@sneakerz.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > No, this patch is a very bad idea for the simple reason that it > makes the mbuf allocator figure out which cpus are absent. > > The mbuf subsystem shouldn't look for holes/sparseness in the > number of cpus. > > The correct thing is to make "mp_ncpus" equal to the max amount > of CPUs in the system, then everything will work properly, not > onlt that but if you ever get a machine with hot swap cpus you > can easily spin up another CPU while running without issues. Okay. Thanks for the review! I like your approach better except for the fact it consumes more resources by creating resource maps and locks for non-existent CPUs. > Lastly, the functions to set mp_ncpus to 1 should be in > machine independant code for non-SMP boxes. Can you say a bit more about what you mean here? -matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010714132021.G29314-100000>