From owner-freebsd-bugs  Tue Jan 27 13:00:06 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id NAA09143
          for freebsd-bugs-outgoing; Tue, 27 Jan 1998 13:00:06 -0800 (PST)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id NAA09125;
          Tue, 27 Jan 1998 13:00:03 -0800 (PST)
          (envelope-from gnats)
Received: from prometheus.frii.com (prometheus.frii.com [208.146.240.73])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id MAA08590
          for <FreeBSD-gnats-submit@freebsd.org>; Tue, 27 Jan 1998 12:57:00 -0800 (PST)
          (envelope-from gnat@prometheus.frii.com)
Received: (from gnat@localhost)
	by prometheus.frii.com (8.8.7/8.8.7) id NAA24796;
	Tue, 27 Jan 1998 13:57:04 -0700 (MST)
	(envelope-from gnat)
Message-Id: <199801272057.NAA24796@prometheus.frii.com>
Date: Tue, 27 Jan 1998 13:57:04 -0700 (MST)
From: gnat@prometheus.frii.com
Reply-To: gnat@prometheus.frii.com
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: bin/5585: _exit(1) in rshd.c, instead of exit(1) ?
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         5585
>Category:       bin
>Synopsis:       _exit(1) in rshd.c, instead of exit(1) ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 27 13:00:02 PST 1998
>Last-Modified:
>Originator:     Nathan Torkington
>Organization:
Front Range Internet, Inc.
>Release:        FreeBSD 2.2.5-STABLE i386
>Environment:

2.2.5-STABLE as of a month or so ago (yeah yeah, I know).

>Description:

Looking through the source to rshd.c, I see that if getpeername()
fails, the error is logged and _exit() is called.  Why is this?  It
looks to me like exit() is called everywhere else.

>How-To-Repeat:

N/A.

>Fix:
	
Change _exit(1) to exit(1) on line 172 of libexec/rshd/rshd.c

>Audit-Trail:
>Unformatted: