Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Feb 2021 09:46:14 -0500
From:      Mark Johnston <markj@freebsd.org>
To:        Mark Millard <marklmi@yahoo.com>
Cc:        dev-commits-src-branches@freebsd.org
Subject:   Re: git: 10ed8ab4ab9b - stable/12 - opencrypto: Fix assignment of crypto  completions to worker threads
Message-ID:  <YBwIttCFyXMcUYEX@raichu>
In-Reply-To: <B5D89157-3FCC-4932-A1E7-BB393088DCC7@yahoo.com>
References:  <B5D89157-3FCC-4932-A1E7-BB393088DCC7.ref@yahoo.com> <B5D89157-3FCC-4932-A1E7-BB393088DCC7@yahoo.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 04, 2021 at 01:40:35AM -0800, Mark Millard wrote:
> 
> The use of atomic_fetchadd_64 broke the 32-bit powerpc and powerpcspe 
> stable/12 builds via the likes of:
> 
> 07:16:19 crypto.o: In function `crypto_newsession':
> 07:16:19 /usr/src/sys/opencrypto/crypto.c:621: undefined reference to `atomic_fetchadd_64'
> 
> from the:
> 
> +	res->id = atomic_fetchadd_64(&sessid, 1);

Thanks for the report, I reverted the change on stable/12 for now.

> (No ci.freebsd.org results exist for stable/13 or for main yet.)

atomic_fetchadd_64 should be available on all platforms in 13 and later.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YBwIttCFyXMcUYEX>