From owner-cvs-all Tue Jul 30 6:28:21 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A6BC37B401 for ; Tue, 30 Jul 2002 06:28:17 -0700 (PDT) Received: from mail.speakeasy.net (mail11.speakeasy.net [216.254.0.211]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEA2243E65 for ; Tue, 30 Jul 2002 06:28:16 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 23153 invoked from network); 30 Jul 2002 13:28:15 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail11.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 30 Jul 2002 13:28:15 -0000 Received: from laptop.baldwin.cx (laptop.baldwin.cx [192.168.0.4]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g6UDSEuR053673; Tue, 30 Jul 2002 09:28:14 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200207301012.g6UACCNY037208@freefall.freebsd.org> Date: Tue, 30 Jul 2002 09:28:18 -0400 (EDT) From: John Baldwin To: Seigo Tanimura Subject: RE: cvs commit: src/sys/kern kern_condvar.c kern_synch.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 30-Jul-2002 Seigo Tanimura wrote: > tanimura 2002/07/30 03:12:11 PDT > > Modified files: > sys/kern kern_condvar.c kern_synch.c > Log: > In endtsleep() and cv_timedwait_end(), a thread marked TDF_TIMEOUT may > be swapped out. Do not put such the thread directly back to the run > queue. Umm, we don't swap out runnable threads do we? I thought we only swapped out sleeping threads. Oh, the state is incorrectly set to TDS_SLP in the code. *sigh* That is grossly wrong because the thread isn't on a sleep queue. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message