From owner-dev-commits-src-main@freebsd.org  Fri Dec 25 22:39:36 2020
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 125604CC547;
 Fri, 25 Dec 2020 22:39:36 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net
 [217.70.183.199])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4D2hhG1fndz4TR1;
 Fri, 25 Dec 2020 22:39:25 +0000 (UTC) (envelope-from avg@FreeBSD.org)
X-Originating-IP: 195.64.148.76
Received: from [192.168.0.24] (unknown [195.64.148.76])
 (Authenticated sender: andriy.gapon@uabsd.com)
 by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 6E313FF803;
 Fri, 25 Dec 2020 22:39:23 +0000 (UTC)
Subject: Re: git: 760dbe84abfb - Don't set more_data which is never used.
To: Xin LI <delphij@FreeBSD.org>, src-committers@FreeBSD.org,
 dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
References: <202012250250.0BP2oJEe076195@gitrepo.freebsd.org>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <1f199cd4-5560-08b2-539b-145945af6dec@FreeBSD.org>
Date: Sat, 26 Dec 2020 00:39:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <202012250250.0BP2oJEe076195@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 4D2hhG1fndz4TR1
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: "Commit messages for the main branch of the src repository."
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Dec 2020 22:39:36 -0000

On 2020-12-25 04:50, Xin LI wrote:
>     Don't set more_data which is never used.
>     
>     MFC after:      2 weeks
> ---
>  usr.sbin/zonectl/zonectl.c | 5 +----

I think it would be better to prepend the commit message with something
like "zonectl:".  Otherwise, using git log --oneline or even just git
log it is hard to tell where the change was made and if it's potentially
of interest to a reader.
Of course, git log --stat reveals that information.

-- 
Andriy