Date: Sat, 26 Dec 2020 00:39:21 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Xin LI <delphij@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 760dbe84abfb - Don't set more_data which is never used. Message-ID: <1f199cd4-5560-08b2-539b-145945af6dec@FreeBSD.org> In-Reply-To: <202012250250.0BP2oJEe076195@gitrepo.freebsd.org> References: <202012250250.0BP2oJEe076195@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-12-25 04:50, Xin LI wrote: > Don't set more_data which is never used. > > MFC after: 2 weeks > --- > usr.sbin/zonectl/zonectl.c | 5 +---- I think it would be better to prepend the commit message with something like "zonectl:". Otherwise, using git log --oneline or even just git log it is hard to tell where the change was made and if it's potentially of interest to a reader. Of course, git log --stat reveals that information. -- Andriy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1f199cd4-5560-08b2-539b-145945af6dec>