From owner-freebsd-ports@FreeBSD.ORG Sat Jan 17 00:41:57 2015 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 08C71E03; Sat, 17 Jan 2015 00:41:57 +0000 (UTC) Received: from mail-we0-x22b.google.com (mail-we0-x22b.google.com [IPv6:2a00:1450:400c:c03::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 88A7F914; Sat, 17 Jan 2015 00:41:56 +0000 (UTC) Received: by mail-we0-f171.google.com with SMTP id u56so22906531wes.2; Fri, 16 Jan 2015 16:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=7vpTwC6pSakjag8tKBTeP03thx+MWF/iDlNRhy3AIiI=; b=n8Ujos7OJZyZ2FcfMQysbOQAiZjaPY8E+jT8kI0bG3SqdwBcBhE+392FOxudugCTir EKBgY2sULOWyVEZH9by8Eg5G32br8vifMqIX2KNDMPa8rDg22Mxf3+kF1URxDc0Yh8+p rVmtkHxP+gV2fpIae1H7EbzGInTVDHco7EQBh6Atr2T3FcuZ4pyGLr7mnzQI0QspBFue i2NEsJvtkNJnrfT8mPwkYhlXCVLz7vr65LMtZoXVrv2DHzPYJrYJg0SyfvdoqgilNg37 o3IduEtRUcx1k3U3tlUav72V1yX+15V8eyXFg+xLFRqh6mrRWMawaVQwLeQ7D0LxaFrG ExRQ== X-Received: by 10.180.101.35 with SMTP id fd3mr10624944wib.6.1421455314793; Fri, 16 Jan 2015 16:41:54 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id x16sm4899313wia.15.2015.01.16.16.41.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jan 2015 16:41:53 -0800 (PST) Sender: Baptiste Daroussin Date: Sat, 17 Jan 2015 01:41:51 +0100 From: Baptiste Daroussin To: Waitman Gobble Subject: Re: postgresql93 port and libedit Message-ID: <20150117004151.GO98528@ivaldir.etoilebsd.net> References: <20150115160113.GE98528@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2IK6idz0sKKouFF6" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: pgsql@FreeBSD.org, freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2015 00:41:57 -0000 --2IK6idz0sKKouFF6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 15, 2015 at 08:02:22PM -0800, Waitman Gobble wrote: > On Thu, Jan 15, 2015 at 8:01 AM, Baptiste Daroussin wr= ote: > > On Wed, Jan 14, 2015 at 10:27:14PM -0800, Waitman Gobble wrote: > >> Hi, > >> > >> I noticed that postgresql93-client port pulls in readline, which is GP= Lv3. > >> When I get rid of readline in Makefile 'USES' and also change the > >> bottom of the Makefile in postgresql93-server, > >> > >> ... > >> .include "${.CURDIR}/../postgresql92-server/Makefile" > >> > >> CONFIGURE_ARGS+=3D--with-libedit-preferred > >> > >> > >> It builds without readline and links against libedit in base: > >> > > except that libedit is not really an alternative as it does not supprot= unicode > > (except in head) one solution would be to try linking against the editl= ine port > > which contains the same fixes as libedit in head and see if it works. > > > > Best regards, > > Bapt >=20 > Thanks so much for the feedback. I've considered the options regarding > my project and I think it's more work to handle end-user devices with > a pkg repository if I indeed must manage custom ports built using > customized sources. Distributing the initial appliance isn't the > problem, i'm working out an update strategy for down the road. >=20 https://people.freebsd.org/~bapt/pglibedit.diff This patch works for me and accepts perfectly unicode. Can anyone from the postgresql team test, generalize to other postegresql versions? (please keep it using the port version of libedit). Best regards, Bapt --2IK6idz0sKKouFF6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlS5r8wACgkQ8kTtMUmk6EyVFACgrQQwEYfqiOk86LWxmvpDdSoT EGMAn1h3N5LlOSYYvB5wxUMJ09kPMZYt =M5/Z -----END PGP SIGNATURE----- --2IK6idz0sKKouFF6--