From owner-freebsd-ports-bugs@FreeBSD.ORG  Tue May 24 15:30:11 2005
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@hub.freebsd.org
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6FDC216A466
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Tue, 24 May 2005 15:30:11 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 54F8F43D48
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Tue, 24 May 2005 15:30:11 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4OFUBZZ074948
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Tue, 24 May 2005 15:30:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4OFUBd3074939;
	Tue, 24 May 2005 15:30:11 GMT (envelope-from gnats)
Date: Tue, 24 May 2005 15:30:11 GMT
Message-Id: <200505241530.j4OFUBd3074939@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Joseph Scott <joseph@randomnetworks.com>
Cc: 
Subject: Re: ports/81405: [update] sysutils/adtool to 1.3
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Joseph Scott <joseph@randomnetworks.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 May 2005 15:30:11 -0000

The following reply was made to PR ports/81405; it has been noted by GNATS.

From: Joseph Scott <joseph@randomnetworks.com>
To: Sergey Matveychuk <sem@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/81405: [update] sysutils/adtool to 1.3
Date: Tue, 24 May 2005 08:23:05 -0700

 On May 24, 2005, at 7:58 AM, Sergey Matveychuk wrote:
 
 > Dear maintainer!
 >
 > Take the PR into account please!
 
 It would be helpful if you simply CC'd me on the original PR, that  
 way I'd know it was there.
 
 I don't approve of this patch.  The white space changes are  
 completely unnecessary, I'm not sure that changing HAS_CONFIGURE to  
 GNU_CONFIGURE is correct, and you also removed the prefix setting for  
 the build (does this tie into GNU_CONFIGURE?).
 
 I appreciate your effort here and would approve the update if the  
 white space changes weren't included and you explained why you want  
 to make the other changes (assuming they turn out to be correct)  
 outside of simply updating the port.
 
 
 --
 Joseph Scott
 URL: http://joseph.randomnetworks.com/
 Email: joseph@randomnetworks.com