From owner-cvs-src@FreeBSD.ORG  Tue Aug 17 23:38:17 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7123A16A4CE; Tue, 17 Aug 2004 23:38:17 +0000 (GMT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3B36D43D1D; Tue, 17 Aug 2004 23:38:17 +0000 (GMT)
	(envelope-from sam@errno.com)
Received: from [66.127.85.91] ([66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.6) with ESMTP id i7HNcFWi073860
	(version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO);
	Tue, 17 Aug 2004 16:38:15 -0700 (PDT)
	(envelope-from sam@errno.com)
From: Sam Leffler <sam@errno.com>
Organization: Errno Consulting
To: Andre Oppermann <andre@FreeBSD.org>
Date: Tue, 17 Aug 2004 16:40:31 -0700
User-Agent: KMail/1.6.1
References: <200408172205.i7HM5sDs087606@repoman.freebsd.org>
	<200408180122.28379.max@love2party.net> <41229617.CB69E0BE@freebsd.org>
In-Reply-To: <41229617.CB69E0BE@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200408171640.31631.sam@errno.com>
cc: Max Laier <max@love2party.net>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/conf files options src/sys/modules/ipfw
	Makefile  src/sys/net bridge.c src/sys/netgraph ng_bridge.c
	src/sys/netinet  ip_divert.c ip_dummynet.c ip_dummynet.h
	ip_fastfwd.c ip_fw.h ip_fw2.c  ip_fw_pfil.c ip_input.c ip_output.c
	...
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Aug 2004 23:38:17 -0000

On Tuesday 17 August 2004 04:34 pm, Andre Oppermann wrote:
> Max Laier wrote:
> > On Wednesday 18 August 2004 00:05, Andre Oppermann wrote:
> > > andre       2004-08-17 22:05:54 UTC
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/conf             files options
> > >     sys/modules/ipfw     Makefile
> > >     sys/net              bridge.c
> > >     sys/netgraph         ng_bridge.c
> > >     sys/netinet          ip_divert.c ip_dummynet.c ip_dummynet.h
> > >                          ip_fastfwd.c ip_fw.h ip_fw2.c ip_input.c
> > >                          ip_output.c ip_var.h raw_ip.c tcp_input.c
> > >                          tcp_sack.c
> > >     sys/sys              mbuf.h
> > >   Added files:
> > >     sys/netinet          ip_fw_pfil.c
> > >   Log:
> > >   Convert ipfw to use PFIL_HOOKS.
> >
> > Excellent!!! Great!!!! Thank you!!!
> >
> > I don't like the hack to bridge.c, but that's marked XXX so I guess you
> > don't either. I hope we can clean this up for RELENG_5_3, though.
>
> No, I don't like it at all.  I have some code ready but did not have time
> to test it before code freeze.  What I want to do is a PFIL_HOOK with
> protocol AF_ETHER which gives you the full layer2 header in the packet.
> What the packet filter does with it is up its implementation.  For example
> it might ignore everthing but IP packets or provide ether header matching
> functionality or such.
>
> I think we (mlaier and me) could cook this up within a week.  Though I'm
> not sure much RE is going to like this kind of changes at this time.

My original version of this work added several new pfil hooks for stuff like 
this.

	Sam