From nobody Fri Nov 4 04:59:47 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N3T2J0Bsqz4h1CR; Fri, 4 Nov 2022 04:59:52 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N3T2H6klDz4Fjm; Fri, 4 Nov 2022 04:59:51 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667537991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L882QerK+1qVZ0BprRu/KJE/+YcEsOj3SwvRDhBUbz0=; b=gT/gqgXIuP5PhuaCuj43L+eu+zdhH857ziTAe2XfMOQJcL1eGNipGH2MKMYs/Q3BC3ij4y 3hMGlOY5dfXuT81kx19EvTE3LiyhPcVySlgYm4CixqPBmuSFqSIgbuTpWEwPry5KLHk7UO BBftNkfhCHD4gVXERE55qV3Myz1gjZL2x4Ykg2JpWHkXo7LGKTpFSFPpN8y/FcBwkcbSjK pOvNXi9pmJad9H+Q8qXrsuDMaO1GM5PvLJoz9HdgcX/9oFicXGIzeNHKRw8RQqYJ9FcjwB qcLtjJrwgNOUKrk6WPK+Q9ta75lx5zkTkCZ80MFcGZ+Sh0ZJ9qjvpwv9o/Cfiw== Received: from [192.168.1.10] (unknown [98.42.164.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4N3T2H260Yz14ZX; Fri, 4 Nov 2022 04:59:51 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.66.22102801 Date: Thu, 03 Nov 2022 21:59:47 -0700 Subject: Re: d0b5e4a30ac9 - main - mana(4): Make the code cross-platform From: Ravi Pokala To: Li-Wen Hsu , , , Message-ID: Thread-Topic: d0b5e4a30ac9 - main - mana(4): Make the code cross-platform References: <202211040416.2A44GGhE047556@gitrepo.freebsd.org> In-Reply-To: <202211040416.2A44GGhE047556@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667537991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L882QerK+1qVZ0BprRu/KJE/+YcEsOj3SwvRDhBUbz0=; b=BPaRlZbZFT/kPc/TK3cAezSSKXSp84rZXlcXH7PtNXtMJwisk72qR3E+i5OHTg48cZwNZU GocKpBmrL9g8spiE5B83MyJpAUfqXSl4CTKqG/usq+MTwRHQ4toBHh+yLFiMaStx+qdFr8 JInQ/Nm0Eni+rHzhXoVnls6e5CcT1lxi3vDMfMyHQ99T4n/IfqJPSDc4bFr/MdjLP/tVhn z9tb0NkIR4XprHeyup27GhXHoxpnbN0WkNlDQfmgOqjMV/+lzn5kLywS/63iddhIz+1vHn DneOkflw4LWwYOrMtpMS/MmNhD37kdloU90Wa3Vic+mG+khmTrugUDA6pGR2ZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667537991; a=rsa-sha256; cv=none; b=EU3G7i+TwYJLXYA/OlzjJYFFCdDarecU0e7n2uXW0RXnawb6HSfw0ZviDPen90kMgZjy9N jfIvHDSpW7oWITi7wc0Q0w3hhqDUKWJJ5YCqgCjw3zvMLMJSWG14ltKatjbf4K9bc8QhsN 88TfRcPypIqb/pfaRherk67mj7Ln3riBKmav0xgrJHpHedtc9gZy8iwK3+5GAuRU+WTHNi UTrPQ2tyMsonCVluLYjGnCxF2+F432OJqp7iqelGny1xDf1RwU9TUEQQz2rmj8AjN6BJKz ZYwRCZ2H92V807pLNhjZvcr/sU0EUjYKHa9gv/FeMo+HxaUHRA0whULxcK2otg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Hi Li-Wen, Shouldn't these new "%ju"s and "%jx"s have (uintmax_t) casts? Thanks, Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: on behalf of Li-Wen Hsu Date: 2022-11-03, Thursday at 21:16 To: , , Subject: git: d0b5e4a30ac9 - main - mana(4): Make the code cross-platform The branch main has been updated by lwhsu: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dd0b5e4a30ac985051c14b0f5e3= cb3e6cdd271929 commit d0b5e4a30ac985051c14b0f5e3cb3e6cdd271929 Author: Li-Wen Hsu AuthorDate: 2022-11-04 03:45:35 +0000 Commit: Li-Wen Hsu CommitDate: 2022-11-04 03:45:35 +0000 mana(4): Make the code cross-platform Discussed with: whu Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D36388 --- sys/dev/mana/mana_en.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/sys/dev/mana/mana_en.c b/sys/dev/mana/mana_en.c index 5e5e3939753f..5a95eff66ab6 100644 --- a/sys/dev/mana/mana_en.c +++ b/sys/dev/mana/mana_en.c @@ -1054,10 +1054,8 @@ mana_cfg_vport(struct mana_port_context *apc, ui= nt32_t protection_dom_id, apc->tx_shortform_allowed =3D resp.short_form_allowed; apc->tx_vp_offset =3D resp.tx_vport_offset; -#if defined(__amd64__) - if_printf(apc->ndev, "Configured vPort %lu PD %u DB %u\n", + if_printf(apc->ndev, "Configured vPort %ju PD %u DB %u\n", apc->port_handle, protection_dom_id, doorbell_pg_id); -#endif out: if (err) @@ -1127,10 +1125,8 @@ mana_cfg_vport_steering(struct mana_port_context= *apc, err =3D EPROTO; } -#if defined(__amd64__) - if_printf(ndev, "Configured steering vPort %lu entries %u\n", + if_printf(ndev, "Configured steering vPort %ju entries %u\n", apc->port_handle, num_entries); -#endif out: free(req, M_DEVBUF); @@ -1694,13 +1690,8 @@ mana_process_rx_cqe(struct mana_rxq *rxq, struct= mana_cq *cq, if (pktlen =3D=3D 0) { /* data packets should never have packetlength of zero */ -#if defined(__amd64__) - if_printf(ndev, "RX pkt len=3D0, rq=3D%u, cq=3D%u, rxobj=3D0x%lx\n", + if_printf(ndev, "RX pkt len=3D0, rq=3D%u, cq=3D%u, rxobj=3D0x%jx\n", rxq->gdma_id, cq->gdma_id, rxq->rxobj); -#else - if_printf(ndev, "RX pkt len=3D0, rq=3D%u, cq=3D%u, rxobj=3D0x%llx\n", - rxq->gdma_id, cq->gdma_id, rxq->rxobj); -#endif return; }