Date: Tue, 04 Sep 2012 10:02:16 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/171325: [PATCH] devel/gdb: Use USE_READLINE=port to ensure port version of readline Message-ID: <201209041502.q84F2LDu062237@freefall.freebsd.org> Resent-Message-ID: <201209041510.q84FA1GR089884@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 171325
>Category: ports
>Synopsis: [PATCH] devel/gdb: Use USE_READLINE=port to ensure port version of readline
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Tue Sep 04 15:10:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Bryan Drewery
>Release: FreeBSD 8.3-RELEASE i386
>Organization:
>Environment:
>Description:
ports/162995 added USE_READLINE=port support to bsd.port.mk. This ensures that the port version is always used.
By switching to using this, we can ensure someone does not accidentally break gdb again, and make portlint happy.
>How-To-Repeat:
>Fix:
--- patch-devel-gdb-use-readline.txt begins here ---
# svn status
M Makefile
Index: Makefile
===================================================================
--- Makefile (revision 303654)
+++ Makefile (working copy)
@@ -39,11 +39,7 @@
ONLY_FOR_ARCHS= i386 amd64 # untested elsewhere, might work
-# Forcing to use readline.6 from ports (newer readline in FreeBSD world is not
-# compatible anymore). Please ignore portlint here.
-LIB_DEPENDS+= readline.6:${PORTSDIR}/devel/readline
-CFLAGS+= -isystem ${LOCALBASE}/include
-LDFLAGS+= -L${LOCALBASE}/lib
+USE_READLINE= port
OPTIONS_DEFINE= DEBUG EXPAT PYTHON THREADS GDB_LINK
GDB_LINK_DESC= Create the gdb link
--- patch-devel-gdb-use-readline.txt ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209041502.q84F2LDu062237>