Date: Sun, 16 Nov 2014 12:35:25 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Olli Hauer <ohauer@FreeBSD.org>, svn-ports-all@freebsd.org, Alfred Perlstein <alfred@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r372622 - in head/editors/vim: . files Message-ID: <20141116113525.GH45145@ivaldir.etoilebsd.net> In-Reply-To: <20141116113345.GG45145@ivaldir.etoilebsd.net> References: <201411160232.sAG2WJ4Z084790@svn.freebsd.org> <54687C89.20206@gmx.de> <F61D76AA4CF82F5E4FC8BFAF@atuin.in.mat.cc> <20141116113345.GG45145@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--4C6bbPZ6c/S1npyF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Nov 16, 2014 at 12:33:45PM +0100, Baptiste Daroussin wrote:
> On Sun, Nov 16, 2014 at 12:24:04PM +0100, Mathieu Arnold wrote:
> > +--On 16 novembre 2014 11:29:29 +0100 olli hauer <ohauer@gmx.de> wrote:
> > |> +.if ${PORT_OPTIONS:MDEFAULT_VIMRC}
> > |> + ${INSTALL_DATA} ${FILESDIR}/vimrc
> > |> ${STAGEDIR}${DEFAULT_VIMRC_LOCATION}/vimrc +.endif
> > |> =20
> > | ...
> > |=20
> > | Thanks for installing a default vimrc file, but isn't it safer to ins=
tall
> > | the vimrc file with the @sample macro to protect users having already=
a
> > | own vimrc file installed?
> >=20
> > Yes, please, install a .sample file and use @sample in the plist, you're
> > going to overwrite people's existing vimrc.
> >=20
> I first asked alfred to do such before the commit.
>=20
> But when looking at how vim handles vimrc this is a fallback location hen=
ce this
> vimrc is only loaded only if there is no user supplied vimrc
>=20
> ':version' will show you:
> system vimrc file: "$VIM/vimrc"
> user vimrc file: "$HOME/.vimrc"
> 2nd user vimrc file: "~/.vim/vimrc"
> user exrc file: "$HOME/.exrc"
> fall-back for $VIM: "/usr/local/share/vim"
>=20
> So now I'm thinking there is no need for a @sample ...vimrc.sample given =
this
> vimrc is doing to be installed in the fall-back location.
>=20
> But I do not think adding yet another option is worth, it should probably=
always
> be installed.
>=20
> Regards,
> Bapt
That said isn't using the default upstream provided vimrc a better option t=
han a
custom one?
/usr/local/share/vim/vim74/vimrc_example.vim as vimrc
and probably /usr/local/share/vim/vim74/gvimrc_example.vim as gvimrc?
Best regards,
Bapt
--4C6bbPZ6c/S1npyF
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlRoi/0ACgkQ8kTtMUmk6ExvCgCfT/ElT4nhSKAnTboF3YYKW8GT
2/YAnAlCIn1cqVwpM7XPBKm8uJKOAiyQ
=+M2p
-----END PGP SIGNATURE-----
--4C6bbPZ6c/S1npyF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141116113525.GH45145>