From owner-freebsd-bugs  Thu Aug 10  8: 6:19 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from midten.fast.no (midten.fast.no [213.188.8.11])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0669837B87D; Thu, 10 Aug 2000 08:06:14 -0700 (PDT)
	(envelope-from tegge@fast.no)
Received: from fast.no (IDENT:tegge@midten.fast.no [213.188.8.11])
	by midten.fast.no (8.9.3/8.9.3) with ESMTP id RAA61158;
	Thu, 10 Aug 2000 17:03:39 +0200 (CEST)
Message-Id: <200008101503.RAA61158@midten.fast.no>
To: steve@sse0691.bri.hp.com
Cc: sheldonh@FreeBSD.org, freebsd-bugs@FreeBSD.org
Subject: Re: kern/20312: IO APIC problems
From: Tor.Egge@fast.no
In-Reply-To: Your message of "Thu, 10 Aug 2000 15:50:17 +0100"
References: <20000810155017.A1450@moose.bri.hp.com>
X-Mailer: Mew version 1.70 on Emacs 19.34.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Date: Thu, 10 Aug 2000 17:03:39 +0200
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

> Firstly, thanks again for taking a look at this, still doesn't work
> though =(

Ouch.  fix_mp_table() probably returns early.

Index: sys/i386/i386/mp_machdep.c
===================================================================
RCS file: /home/ncvs/src/sys/i386/i386/mp_machdep.c,v
retrieving revision 1.118
diff -u -r1.118 mp_machdep.c
--- sys/i386/i386/mp_machdep.c	2000/08/06 00:04:02	1.118
+++ sys/i386/i386/mp_machdep.c	2000/08/10 15:00:22
@@ -1155,12 +1170,10 @@
 	 */
 
 	/* check the 1 PCI bus case for sanity */
-	if (num_pci_bus == 1) {
-
-		/* if it is number 0 all is well */
-		if (bus_data[bus_pci].bus_id == 0)
-			return;
-
+	/* if it is number 0 all is well */
+	if (num_pci_bus == 1 &&
+	    bus_data[bus_pci].bus_id != 0) {
+		
 		/* mis-numbered, swap with whichever bus uses slot 0 */
 
 		/* swap the bus entry types */


- Tor Egge


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message