From nobody Wed Jul 23 14:23:56 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bnGbJ48TFz62NjS; Wed, 23 Jul 2025 14:23:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bnGbJ2Vz0z3pdF; Wed, 23 Jul 2025 14:23:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753280636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X8lF0ivMPgTWl63936fCL/pKZV5IYWrcGxrCI30HpcY=; b=U3sepEXPHyk/XMj5Rr4ulpZqXgmxKjmyd0TRC586o1xRWjtPonMD4OQiajoe83mcFOVE2M pUyHF4KmW08HqYRyjo7DfoBFSUwVTZAFIzFQ/RMobxrTkt4J+nMBfWIptae4pi2S7Gsl2g JwPVIvxLKmXk7frSUvr9eT/qjI3Q0cqXHvyWL/ZR4jcJS7eOM7ar4yDpr+DW84WdDELQZ5 Px6G/Va+OdwmLU7BZHKPZ7V6xrAXRSymN21mYoKkuPkCHKi0RfgSrZJPRyjNDDsB16ZpTC MNaeHK+OmYHVitiZGTypEeLr/Z+zgx6DecqDGPF9MVbP8UCbH3KbtqgugoqfbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753280636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X8lF0ivMPgTWl63936fCL/pKZV5IYWrcGxrCI30HpcY=; b=hpNXeekHHPjv4IsngUfBHRCZj6P7aYRDlVrAzXIKducjoFSOzwqhOwDi1KdWwl2W7T8gG2 ymjeCbDy39Xaf9Pun688UQretBJPzp4gZT/JbIAkeGYOV2/Q/1CWzZ8Rv4K67OKihOsq7g 57e6T1R6sNLWIcNiqwULFkqmsW0mUIsak3U2n2xNrvyBD6Ej9R/SkT45B/Y8rOayeHohV1 V+sA/YDm3tgyLKZ3kbekI7OtRIv+T2ry+6UxeTM2obHAfwSKRtqH4Hm9X3QHq1C7yG/pU1 9YLVUCUgxPWHQMH8+1uHekGsMJWNgvQ6IxMtVjAntpJojD9gO0dkZT1aD3oExA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753280636; a=rsa-sha256; cv=none; b=YVUz7on8W3SS4APpgpxHtEUwj5I7wuq5lK1vSsEiZlyE3Q+zzD4Kj9fO9vVVlcGTNSMLub aYi/UttbB5HJ4Ul4f9HyK69KWD9Gv83yAAAWwi6m3w5UAwp1ozRMsTXIEk0R4ppiSBq2uU pCIzSClOaB27nu7qK1xXTofHxpgnOShdcE8Ymnt29u29o8SOHJu9Ppf3ygRj/2rVE9YOEb 58rcKV0Y/A7V7JmnYSzz3f0+Rn+bl0/CWerNSqilm5XD2s2Nn81zPOEZSxYkPV5pxdPQ/M pkvVUmzHfZqgkVz7AHYW0Dd6vhbvHO2c4NNCEIez0+2P83jycDu6y9dRJfR/lg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bnGbJ1yJKz1Lx; Wed, 23 Jul 2025 14:23:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56NENusX031434; Wed, 23 Jul 2025 14:23:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56NENu80031431; Wed, 23 Jul 2025 14:23:56 GMT (envelope-from git) Date: Wed, 23 Jul 2025 14:23:56 GMT Message-Id: <202507231423.56NENu80031431@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: e83df5367d30 - main - if_ovpn: fill out sin_len/sin6_len List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e83df5367d30761803e09bd7fcf518638dfe43d2 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=e83df5367d30761803e09bd7fcf518638dfe43d2 commit e83df5367d30761803e09bd7fcf518638dfe43d2 Author: Kristof Provost AuthorDate: 2025-07-22 12:41:20 +0000 Commit: Kristof Provost CommitDate: 2025-07-23 13:35:48 +0000 if_ovpn: fill out sin_len/sin6_len When we parse an nvlist sockaddr we should set the sockaddr_in(6)'s length field. This isn't currently used by anything yet, but it's reasonable to expect a sockaddr to contain its length. MFC after: 3 weeks Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/net/if_ovpn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/net/if_ovpn.c b/sys/net/if_ovpn.c index 7bdbc565f4ca..6755997fd1f0 100644 --- a/sys/net/if_ovpn.c +++ b/sys/net/if_ovpn.c @@ -341,6 +341,7 @@ ovpn_nvlist_to_sockaddr(const nvlist_t *nvl, struct sockaddr_storage *sa) size_t len; const void *addr = nvlist_get_binary(nvl, "address", &len); in->sin_family = af; + in->sin_len = sizeof(*in); if (len != sizeof(in->sin_addr)) return (EINVAL); @@ -355,6 +356,7 @@ ovpn_nvlist_to_sockaddr(const nvlist_t *nvl, struct sockaddr_storage *sa) size_t len; const void *addr = nvlist_get_binary(nvl, "address", &len); in6->sin6_family = af; + in6->sin6_len = sizeof(*in6); if (len != sizeof(in6->sin6_addr)) return (EINVAL);