From owner-svn-src-head@freebsd.org Wed Jan 10 17:55:55 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1A6EE6B4BB; Wed, 10 Jan 2018 17:55:55 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8EE0681DA0; Wed, 10 Jan 2018 17:55:55 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (astound-66-234-199-215.ca.astound.net [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id DD42F10AF2A; Wed, 10 Jan 2018 12:55:48 -0500 (EST) From: John Baldwin To: Warner Losh Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327705 - head/stand/mips/beri/common Date: Wed, 10 Jan 2018 09:20:05 -0800 Message-ID: <46003356.LuRHu4Xbkq@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: References: <201801081847.w08IlZ7F033684@repo.freebsd.org> <1620808.I0a57TDRna@ralph.baldwin.cx> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 10 Jan 2018 12:55:49 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 17:55:55 -0000 On Tuesday, January 09, 2018 10:48:30 AM Warner Losh wrote: > On Tue, Jan 9, 2018 at 10:05 AM, John Baldwin wrote: > > > On Monday, January 08, 2018 12:02:09 PM Warner Losh wrote: > > > This should have been a nop... libsa specifically creates 'safe' headers > > > for all the standard ones. > > > > > > Ah, libsa creates a perfectly fine stdint.h, but not a inttypes.h... > > > > Would you prefer it to use stdint.h and stdio.h rather than stand.h? > > > No. stand.h is fine. I just wondered why you hit issues at all with > stdio.h. inttypes.h isn't supported because we don't implement the extra > functions defined there over stdint.h, so it should have given an error > when included. I'm just surprised I didn't catch it in my universe.sh > script that I use to build all loaders though... FWIW, compiling with external GCC did not trip over this (so in-tree GCC probably didn't either). Only compiling with clang (for which I still have some out-of-tree patches) tripped over this. -- John Baldwin