From owner-freebsd-net@FreeBSD.ORG Wed Jun 20 08:13:18 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 87A17106566C for ; Wed, 20 Jun 2012 08:13:18 +0000 (UTC) (envelope-from guyong1978@hotmail.com) Received: from snt0-omc2-s32.snt0.hotmail.com (snt0-omc2-s32.snt0.hotmail.com [65.55.90.107]) by mx1.freebsd.org (Postfix) with ESMTP id 58EAB8FC0C for ; Wed, 20 Jun 2012 08:13:18 +0000 (UTC) Received: from SNT112-W22 ([65.55.90.72]) by snt0-omc2-s32.snt0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 20 Jun 2012 01:12:12 -0700 Message-ID: X-Originating-IP: [194.237.142.17] From: GuYong To: Date: Wed, 20 Jun 2012 08:12:12 +0000 Importance: Normal MIME-Version: 1.0 X-OriginalArrivalTime: 20 Jun 2012 08:12:12.0604 (UTC) FILETIME=[656C7FC0:01CD4EBC] Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Question about MLDv2 implemenation in Kernel X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2012 08:13:18 -0000 Hi, everyone, I'm looking at the MLDv2 implemenation in kernel, and there seem to be some issues, could anyone confirm them? 1. RFC3810 clause 6.1 mentions there is a Source Retransmission Counter associated to each source, so that the merged report could contain the content that is interrupted by a new state change report BUT, I didn't see this is implemented currently! 2. Regarding the 'Older Version Querier Present timer', the code is like this:old_version_timer = (mli->mli_rv * mli->mli_qi) + mli->mli_qri; while mli->mli_qri = maxdelay, and maxdelay = ntohs(mld->mld_maxdelay). BUT, mld_maxdelay is in units of milliseconds (clause 5.1.3), I think it should be divided by 1000 before it adds to old_version_timer. 3. According to RFC, a node MUST accept and process any Query whose IP Destination Address field contains *any* of the address (unicast or multicast) assigned to the interface on which the Query arrives. BUT, I see the code only accept General Query addressed to FF02::1. Best Regards,Yong