From nobody Wed Apr 15 13:47:02 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fwj9z0cVhz6ZtfG for ; Wed, 15 Apr 2026 13:47:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fwj9y5cwxz3mJ4 for ; Wed, 15 Apr 2026 13:47:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776260822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cWlFT7Vuo74p54zN16KYUSkddWXWmakrBwfe6eIqsz4=; b=moUISRelcW4qZh3G1jprtfLd2X7Z5pgtbxCUXqTuW8GlDUuRIzjP45y1L+dqKoB1t7QvbQ wlawSXbgAqlR+TltEgrnHAWZgSPYQPN3LOho9LqPZzHEICvWGTFbxTz07u/UaTfQSsnJcB 7T+RuGcLI28CPY2cgXHSY4F7Jifra2dNIULxlzhnXziKkDEjnw46KYDN/NF0YA/3UkSuB5 wyKJrkzTHNKqmHpq+0RT/YtqIegffYsS8EkOD7fw5QJhGyk3mZbe9CwSgnLUwMmu/Z1TQi HORcyXLkBLW3ZG8UXo0mePuM6HVxKXlcM/Us+jCicQEiQDE/kOZp3pxVlU6bJQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776260822; a=rsa-sha256; cv=none; b=PFgPbnvKyDko8gKSCMmZdh3geequ2hs5PF9aLtvy2SyJg76H9Qwp20XyCgyemZid4rFClR 4f6wA+dDmAOn5GgcnBX0T9narjj+dGsBv6zKXHLdVKTOn0M6nKgS5r8m34C7JpuGyQNPN1 esfuxdGL2RosRRF50jSieqaXuyr/Ddynha9lgBh9256eFXuGZ2NZq9Y+AZeAJVejvRCq4f DZI4DnjFA8INBOupcY2I8qrGcvaa8BHDe0QyEd8cmY0+bxA0HsX5+O6Q6VtwPa9L1i39fd vOYpr3VNXIjB/U3ViFTYHq0gnkXxLcDunhhuhKFcUxC8eRpTMYhgU8jYSLCEFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776260822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cWlFT7Vuo74p54zN16KYUSkddWXWmakrBwfe6eIqsz4=; b=B4A+jjYR+fkHqqGCllvaM9hms5pytMYa7vn8zcp9xOf3bhete9NEICb25WFLarl1h3mHko OQeN+eabEc/pehk46kYQIih0KN93hTKaZADp6u3IxGG40TrYG2mV1hFARPhP+i8LcWruP7 gdRzP5ebbYZBJMeJJX0VriTaG3gk2DiMpSolJE0zjLccrq2orWKk9MBOZLnWvgo0NGXwKX M2KBaR2XFfzZ2Iy7RB46SsTt1ev0OptQZB2QIJxVMrDI2/kfs1NEKIy4gYYfXVWzRPOZ+M i5y8YdtzD0cd/1W7ruG6ax3bHNMLRUArQ/+vsVcQqZZzmnRjXeW6her6mdMejA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fwj9y5DlXz7bB for ; Wed, 15 Apr 2026 13:47:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 432d6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 15 Apr 2026 13:47:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 52d2fc702b85 - main - linuxkpi: Fix an off-by-one error in the kfifo implementation List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 52d2fc702b85d56b35f8828fe7efca3cde0d25b7 Auto-Submitted: auto-generated Date: Wed, 15 Apr 2026 13:47:02 +0000 Message-Id: <69df96d6.432d6.17bbc698@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=52d2fc702b85d56b35f8828fe7efca3cde0d25b7 commit 52d2fc702b85d56b35f8828fe7efca3cde0d25b7 Author: Mark Johnston AuthorDate: 2026-04-15 13:33:04 +0000 Commit: Mark Johnston CommitDate: 2026-04-15 13:33:04 +0000 linuxkpi: Fix an off-by-one error in the kfifo implementation "total" is the number of slots in the array, so wraparound needs to be done when "first" or "last" is greater than or equal to the number of slots. Note that no consumers of the code are currently connected to the kernel build. Reported by: Stanislav Fort Reviewed by: bz, emaste MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D56371 --- sys/compat/linuxkpi/common/include/linux/kfifo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/include/linux/kfifo.h b/sys/compat/linuxkpi/common/include/linux/kfifo.h index fbe16e22683e..b0d0c17f07e4 100644 --- a/sys/compat/linuxkpi/common/include/linux/kfifo.h +++ b/sys/compat/linuxkpi/common/include/linux/kfifo.h @@ -89,7 +89,7 @@ (_kf)->head[(_kf)->last] = (_e); \ (_kf)->count++; \ (_kf)->last++; \ - if ((_kf)->last > (_kf)->total) \ + if ((_kf)->last >= (_kf)->total) \ (_kf)->last = 0; \ _rc = true; \ } \ @@ -107,7 +107,7 @@ *(_e) = (_kf)->head[(_kf)->first]; \ (_kf)->count--; \ (_kf)->first++; \ - if ((_kf)->first > (_kf)->total) \ + if ((_kf)->first >= (_kf)->total) \ (_kf)->first = 0; \ _rc = true; \ } \