From nobody Fri Nov 26 08:10:31 2021 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C58C118A869F; Fri, 26 Nov 2021 08:10:34 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J0nVf3t8sz4hq7; Fri, 26 Nov 2021 08:10:34 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4DB3023E0E; Fri, 26 Nov 2021 08:10:34 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 9D82252019; Fri, 26 Nov 2021 09:10:31 +0100 (CET) Date: Fri, 26 Nov 2021 09:10:31 +0100 From: Baptiste Daroussin To: Yasuhiro Kimura Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: ae1787aab23e - main - shells/zsh: Add BASE_ZSH option Message-ID: <20211126081031.gwbnmgrtwwr7umon@aniel.nours.eu> References: <202111260055.1AQ0tAJY022570@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202111260055.1AQ0tAJY022570@gitrepo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637914234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mq906ChMaL+HV+9UQRYVEPjb+Vo9FDqF+8V/xPoJAxM=; b=SQyun8dVSWNJVfZc528mTRiM/eY6oMZfARbk29BHhIOghAlkwOGJwXhun1nkJlSY9jQs8p lPbBUSn6RtuF9HaIBUlMOwEC+gtr5dXim/HFVUlorN0NQLUxGXsIlXASsWeCaJOVM2HlKh X8BXiiH2kkEDRDIPEvtW3ICxUxA4TUnMywkNB6/hys0TuxyQSAaBLDHeKeuNuCaH4V+rhu 1xtkMJUgfTUe4dN69s28fjBQN0/1SnkSdIlI5i+e6VY5cpcrQwAOL83n1+qj7Ry7FRfVwn ddoSi03tsFumBq9dtbEvY4s0GPi/V1s5ElNdF0PxZ7cE5yHo4D/ptyrCdqiWRQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637914234; a=rsa-sha256; cv=none; b=f11wP/cSWxHmZ6B5syh/CtsjWi3quD0Ab7qMbiGy0cDPp8H5VcBrepKRRSjWOZ3SuP5pJE +Vsz91fd5jVD1P8wcdyGhMUJPMTTiTDVo5hVRHpZCesNdT0G9NlDbl4u7IIoeYD9q4cx8l InY4q6cRCSeGo4VFD7WbZKOE2yzesHjFuqhJ7HZAz+lD48ETC5O7MvVc6oM5yRf6Abt36h LWoRkT09wBv3tFylI9fajX7hmV0MYGmuHYz27ZvgHyc78qmaseGkA19203ooog7tLCyxVF YPbNsE8Dqz8RnPEZTTT7ogWr1hUR9nZyqbbRo4KsUV5KVNzP9vWz2+f6RjD6PQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Fri, Nov 26, 2021 at 12:55:10AM +0000, Yasuhiro Kimura wrote: > The branch main has been updated by yasu: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ae1787aab23e44e369dbb0cc814e8318c6f86e0d > > commit ae1787aab23e44e369dbb0cc814e8318c6f86e0d > Author: Yasuhiro Kimura > AuthorDate: 2021-10-12 16:47:27 +0000 > Commit: Yasuhiro Kimura > CommitDate: 2021-11-26 00:53:36 +0000 > > shells/zsh: Add BASE_ZSH option > > Add new option BASE_ZSH that makes zsh and rzsh also available as > /bin/zsh and /bin/rzsh. > > Under ports flamework everything is installed under /usr/local unless > custom prefix is used. And according to it zsh is installed as > /usr/local/bin/zsh. But on most Linux based OSes zsh is installed as > /bin/zsh. And it causes problem if user's account information is > shared between FreeBSD and Linux by using such tools as LDAP or NIS as > account information also includes absolute path of user's login shell. > To work around it I have created /bin/zsh as symbolic link referencing > /usr/local/bin/zsh and also edited /etc/shells to add /bin/zsh to it > every time I set up new FreeBSD system. But it's quite bothersome and > that is why I add new BASE_ZSH option. > > While I'm here, > > * Pet portclippy > * Re-format Makefile with portfmt > > PR: 259109 > Proposed by: Chris Hutchinson (more intuitive option name) > Approved by: maintainer timeout (> 2 weeks) > --- > shells/zsh/Makefile | 80 ++++++++++++++++++++++++++++------------------------ > shells/zsh/pkg-plist | 2 ++ > 2 files changed, 45 insertions(+), 37 deletions(-) Please revert, sorry I should have seen and replied to this PR which I didn't. We have been fighting for years to try to reduce the number of ports installing things in the base system. Best regards, Bapt