From owner-svn-src-head@FreeBSD.ORG Thu Nov 29 12:01:59 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C2D55A7; Thu, 29 Nov 2012 12:01:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 8877D8FC0C; Thu, 29 Nov 2012 12:01:58 +0000 (UTC) Received: from tom.home (localhost [127.0.0.1]) by kib.kiev.ua (8.14.5/8.14.5) with ESMTP id qATC1l5G057758; Thu, 29 Nov 2012 14:01:47 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.7.1 kib.kiev.ua qATC1l5G057758 Received: (from kostik@localhost) by tom.home (8.14.5/8.14.5/Submit) id qATC1lDN057757; Thu, 29 Nov 2012 14:01:47 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 29 Nov 2012 14:01:47 +0200 From: Konstantin Belousov To: Eitan Adler Subject: Re: svn commit: r243665 - head/sbin/dump Message-ID: <20121129120147.GE3013@kib.kiev.ua> References: <201211290516.qAT5GoT5098709@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qCuyVVLLFvr0p6ls" Content-Disposition: inline In-Reply-To: <201211290516.qAT5GoT5098709@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2012 12:01:59 -0000 --qCuyVVLLFvr0p6ls Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 29, 2012 at 05:16:50AM +0000, Eitan Adler wrote: > Author: eadler > Date: Thu Nov 29 05:16:50 2012 > New Revision: 243665 > URL: http://svnweb.freebsd.org/changeset/base/243665 >=20 > Log: > Mark non-returning function as such > =20 > PR: bin/172978 > Approved by: cperciva > MFC after: 3 days >=20 > Modified: > head/sbin/dump/dump.h >=20 > Modified: head/sbin/dump/dump.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sbin/dump/dump.h Thu Nov 29 03:48:39 2012 (r243664) > +++ head/sbin/dump/dump.h Thu Nov 29 05:16:50 2012 (r243665) > @@ -121,7 +121,7 @@ void trewind(void); > void writerec(char *dp, int isspcl); > =20 > void Exit(int status) __dead2; > -void dumpabort(int signo); > +void dumpabort(int signo) __dead2; > void dump_getfstab(void); > =20 > char *rawname(char *cp); What is the goal of this change ? It is arguably backward. There is absolutely no use to mark signal handler as __dead2, and all other uses do not benefit from the redundand declaratio= n. Also, being quite removed from the function definition, there is a chance that some future modification would make the attribute a lie. --qCuyVVLLFvr0p6ls Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlC3TqsACgkQC3+MBN1Mb4gUFACgpYhL1B/3guz8Tlgck1sj4wGn 2ugAoMqd9AWWaF+qby3HusN/pzOGnr3d =kUCf -----END PGP SIGNATURE----- --qCuyVVLLFvr0p6ls--