From owner-freebsd-multimedia@FreeBSD.ORG Wed Apr 19 08:27:21 2006 Return-Path: X-Original-To: multimedia@freebsd.org Delivered-To: freebsd-multimedia@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3EB5516A400; Wed, 19 Apr 2006 08:27:21 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id B569343D49; Wed, 19 Apr 2006 08:27:20 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (6zbp0rk13drgdohd@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.4/8.13.3) with ESMTP id k3J8RJIm069700; Wed, 19 Apr 2006 01:27:19 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.4/8.13.3/Submit) id k3J8RHIp069699; Wed, 19 Apr 2006 01:27:17 -0700 (PDT) (envelope-from jmg) Date: Wed, 19 Apr 2006 01:27:17 -0700 From: John-Mark Gurney To: Alexander Leidinger Message-ID: <20060419082716.GJ38619@funkthat.com> Mail-Followup-To: Alexander Leidinger , multimedia@freebsd.org, arch@freebsd.org References: <20060418032520.GG38619@funkthat.com> <20060419094909.pt0jmp5n4scg4kg4@netchild.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060419094909.pt0jmp5n4scg4kg4@netchild.homeip.net> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: arch@freebsd.org, multimedia@freebsd.org Subject: Re: drop snd_ from DRIVER_MODULEs... X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 08:27:21 -0000 Alexander Leidinger wrote this message on Wed, Apr 19, 2006 at 09:49 +0200: > Quoting John-Mark Gurney (from Mon, 17 > Apr 2006 20:25:20 -0700): > > >Well, I noticed that we have a few extra snd_'s in front of most (all?) > > If it's not in front of all drivers for sound chips (!= all modules > which make up the sound system), it's an inconsistency which should be > fixed. > > >of our sound drives.. I believe this used to be necessary due to lack of > >kldxref which couldn't find modules w/ different names than the modules.. > >Now that this has been fixed, I feel that we should drop these so we > >don't have issues w/ name mismatches, such as introduced w/ gusc and sbc.. > > What are the benefits of this patch? Why should we commit it? What's > wrong with the current way of naming? How is this patch an improvement? > > I don't object to the patch (haven't tested it), but what are the benefits? The benifits are more consistant naming of our modules... Only three ethernet modules have if_ in front, and the rest are the raw device names.. It also means that the module names matches more closely to the driver that implemented by them (though this is a bit complicated w/ the fact that pcm is the real driver behind these modules and pcm isn't it's own device node)... It also makes my driver/module dependancy script do the correct thing wrt to gusc and sbc.. (The graph can be seen at: http://people.FreeBSD.org/~jmg/driver.pdf )... With out this change gusc and sbc would be their own sub-graphs not connected to anything besides their children... Though I do realize that sound module names are special since they can (and do) end in numbers which none of our other drivers do... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."