From owner-cvs-all@FreeBSD.ORG Mon Jan 26 07:47:30 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FAFE16A4CE for ; Mon, 26 Jan 2004 07:47:30 -0800 (PST) Received: from mail2.speakeasy.net (mail2.speakeasy.net [216.254.0.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A83743D8B for ; Mon, 26 Jan 2004 07:45:52 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 5547 invoked from network); 26 Jan 2004 15:36:15 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 26 Jan 2004 15:36:15 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i0QFaBM0049988; Mon, 26 Jan 2004 10:36:11 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Jeff Roberson , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Date: Mon, 26 Jan 2004 10:26:56 -0500 User-Agent: KMail/1.5.4 References: <200401250503.i0P53EoN026914@repoman.freebsd.org> In-Reply-To: <200401250503.i0P53EoN026914@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200401261026.56106.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) Subject: Re: cvs commit: src/sys/i386/i386 local_apic.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2004 15:47:30 -0000 On Sunday 25 January 2004 12:03 am, Jeff Roberson wrote: > jeff 2004/01/24 21:03:14 PST > > FreeBSD src repository > > Modified files: > sys/i386/i386 local_apic.c > Log: > - Don't define DETECT_DEADLOCK. I don't know that this code has > detected a deadlock in several years. Furthermore, the IPI code is > currently protected by a seperate spinlock. This only served to make IPIs > twice as expensive as they had to be which severely slowed down the IPI > heavy ULE scheduler. What spinlock? > grep mtx local_apic.c | wc -l 0 Some users of the ipi API use a spinlock themselves, but not all, and there certainly isn't a global ipi spin lock. According to witness, only sparc64 has an ipi spin lock. It might still be a good idea to turn this off or perhaps at least half of it. We will lose ipi's on non-XAPIC systems if you don't wait for the delivery status to clear before sending an IPI. Have you tested this on Pentium II's or earlier? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org