Date: Tue, 29 Aug 1995 04:57:42 -0700 From: Satoshi Asami <asami> To: CVS-commiters, cvs-share Subject: cvs commit: src/share/mk bsd.port.mk Message-ID: <199508291157.EAA25460@freefall.FreeBSD.org>
next in thread | raw e-mail | index | archive | help
asami 95/08/29 04:57:42 Modified: share/mk bsd.port.mk Log: Don't trust ncftp's exit status, they are not indicative of whether the file is fetched or not. Apparently Jordan fixed it a long time ago but it was broken again at import of the new version of ncftp. Which means even if we fix it, it may break again and we may need to fix it again, and (imagination here, please).... Instead, move the file existence check into the for loop for MASTER_SITES/PATCH_SITES and break out with "continue 2" when the file is found. This is actually a cleaner logic than before if you ask me, because instead of assuming the file is fetched on a 0 exit status from ncftp AND checking for the existence of the file after the loop, the check is done exactly once for each iteration and nowhere else.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508291157.EAA25460>