From owner-freebsd-current@FreeBSD.ORG Tue Mar 24 16:08:42 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86DD01065787 for ; Tue, 24 Mar 2009 16:08:42 +0000 (UTC) (envelope-from gperez@entel.upc.edu) Received: from violet.upc.es (violet.upc.es [147.83.2.51]) by mx1.freebsd.org (Postfix) with ESMTP id E591C8FC13 for ; Tue, 24 Mar 2009 16:08:41 +0000 (UTC) (envelope-from gperez@entel.upc.edu) Received: from hamilton.upcnetadm.upcnet.es (hamilton.upcnetadm.upcnet.es [147.83.2.240]) by violet.upc.es (8.14.1/8.13.1) with ESMTP id n2OG8WHq022821 for ; Tue, 24 Mar 2009 17:08:32 +0100 Received: from [147.83.40.234] ([147.83.40.234]) by hamilton.upcnetadm.upcnet.es (Lotus Domino Release 5.0.12) with ESMTP id 2009032417084036:177872 ; Tue, 24 Mar 2009 17:08:40 +0100 Message-ID: <49C90508.4030500@entel.upc.edu> Date: Tue, 24 Mar 2009 17:06:32 +0100 From: Gustau Perez User-Agent: Thunderbird 2.0.0.21 (X11/20090323) MIME-Version: 1.0 CC: freebsd-current@freebsd.org References: <49C80DBA.80407@entel.upc.edu> <790a9fff0903240842k6ab28ab5k1d1a46714fdfe804@mail.gmail.com> In-Reply-To: <790a9fff0903240842k6ab28ab5k1d1a46714fdfe804@mail.gmail.com> X-MIMETrack: Itemize by SMTP Server on hamilton/UPC(Release 5.0.12 |February 13, 2003) at 24/03/2009 17:08:40, Serialize by Router on hamilton/UPC(Release 5.0.12 |February 13, 2003) at 24/03/2009 17:08:40, Serialize complete at 24/03/2009 17:08:40 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1; format=flowed X-Mail-Scanned: Criba 2.0 + Clamd X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (violet.upc.es [147.83.2.51]); Tue, 24 Mar 2009 17:08:32 +0100 (CET) Subject: Re: Inline definition problem in current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2009 16:08:50 -0000 >> >> It seems like they might be related. >> >> >> Hope that helps. >> >> Yes it did. > I can confirm that reverting this change allows the audio/faad port to build. > > Instead of reverting that change, it would be better to change the offeding inline function definition to something like : extern inline [return type|void] __attribute__((gnu_inline)) function_name(arg1,arg2,...) and the function implementation should be the same without the extern. That allowed me to compile compiz-fusion-plugins-main in current and run it. I'm found the problem you faced, but didn't know how to fix it, so I used an static inline definition (which is not the solution). I'm going to try this patch in stable branch (which doesn't need this change). If it works a PR can be send to fix both current and stable without tricks in the makefile. Greets,