From owner-svn-src-head@freebsd.org  Tue Jun  5 00:00:25 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 621C0FE9409;
 Tue,  5 Jun 2018 00:00:25 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BC42B6EF84;
 Tue,  5 Jun 2018 00:00:24 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w5500Mlh098071;
 Mon, 4 Jun 2018 17:00:22 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w5500Men098070;
 Mon, 4 Jun 2018 17:00:22 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201806050000.w5500Men098070@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r334630 - head/usr.bin/indent
In-Reply-To: <201806042024.w54KOWPt045801@repo.freebsd.org>
To: Piotr Pawel Stefaniak <pstef@freebsd.org>
Date: Mon, 4 Jun 2018 17:00:22 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jun 2018 00:00:25 -0000

> Author: pstef
> Date: Mon Jun  4 20:24:31 2018
> New Revision: 334630
> URL: https://svnweb.freebsd.org/changeset/base/334630
> 
> Log:
>   indent(1): remove static const char copyright[]
>   
>   It repeats what is already said in the heading comment and it's optimized out
>   so serves no purpose.

The purpose would be to put a copyright into the binary, and why that is not
happening when the original authors intended that is not good.

This is a regression, as 5.4p8 shows:
{108}% strings /usr/bin/indent | grep -i copy
bcopy
@(#) Copyright (c) 1985 Sun Microsystems, Inc.
@(#) Copyright (c) 1976 Board of Trustees of the University of Illinois.
@(#) Copyright (c) 1980, 1993

Please walk very very very carefully around all things "copyright".

> Modified:
>   head/usr.bin/indent/indent.c
> 
> Modified: head/usr.bin/indent/indent.c
> ==============================================================================
> --- head/usr.bin/indent/indent.c	Mon Jun  4 20:21:51 2018	(r334629)
> +++ head/usr.bin/indent/indent.c	Mon Jun  4 20:24:31 2018	(r334630)
> @@ -35,14 +35,6 @@
>   * SUCH DAMAGE.
>   */
>  
> -#ifndef lint
> -static const char copyright[] =
> -"@(#) Copyright (c) 1985 Sun Microsystems, Inc.\n\
> -@(#) Copyright (c) 1976 Board of Trustees of the University of Illinois.\n\
> -@(#) Copyright (c) 1980, 1993\n\
> -	The Regents of the University of California.  All rights reserved.\n";
> -#endif /* not lint */
> -
>  #if 0
>  #ifndef lint
>  static char sccsid[] = "@(#)indent.c	5.17 (Berkeley) 6/7/93";
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org