From owner-freebsd-bugs@FreeBSD.ORG Sat Mar 6 23:50:15 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD5F916A4CE for ; Sat, 6 Mar 2004 23:50:15 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8B0B443D1D for ; Sat, 6 Mar 2004 23:50:15 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i277oFbv007015 for ; Sat, 6 Mar 2004 23:50:15 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i277oFku007011; Sat, 6 Mar 2004 23:50:15 -0800 (PST) (envelope-from gnats) Date: Sat, 6 Mar 2004 23:50:15 -0800 (PST) Message-Id: <200403070750.i277oFku007011@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Dmitry Morozovsky Subject: Re: kern/63839: [patch] vinum fake-disklabel block/frag fix X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dmitry Morozovsky List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Mar 2004 07:50:15 -0000 The following reply was made to PR kern/63839; it has been noted by GNATS. From: Dmitry Morozovsky To: "Greg 'groggy' Lehey" Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: kern/63839: [patch] vinum fake-disklabel block/frag fix Date: Sun, 7 Mar 2004 10:41:36 +0300 (MSK) On Sun, 7 Mar 2004, Greg 'groggy' Lehey wrote: GgL> > This patch changes vinum fake-disklabel block/frag size from default 8k/1k to GgL> > more approppriate for modern disks 16k/2k. Also, it removes duplicate GgL> > assignment. It applies to both -current and -stable. GgL> GgL> Why do you want to do this? When do you ever use the "label"? I'd GgL> much rather see the label go away. It's not needed for anything that GgL> I know about. Not exactly ;-) Yes, AFAIK it is not needed in -current, but it simplify newfs'ing Vinum volume under -stable, where newfs uses fake disklabel info to determine default frag/block size. Before this patch news with default parameters would use root@whale:/# newfs -N -v /dev/vinum/obj Warning: Block size and bytes per inode restrict cylinders per group to 22. Warning: 1536 sector(s) in last cylinder unallocated /dev/vinum/obj: 25164288 sectors in 6144 cylinders of 1 tracks, 4096 sectors 12287.2MB in 280 cyl groups (22 c/g, 44.00MB/g, 10944 i/g) super-block backups (for fsck -b #) at: 32, 90144, 180256, 270368, 360480, 450592, 540704, 630816, 720928, 811040, [...] So you should explicitely use -f/-b for setting 2k/16k. After patch, you will automagically get more appropriate for multi-gigabyte partition blocksizes: root@whale:/# newfs -N -v /dev/vinum/obj Warning: Block size and bytes per inode restrict cylinders per group to 89. Warning: 1536 sector(s) in last cylinder unallocated /dev/vinum/obj: 25164288 sectors in 6144 cylinders of 1 tracks, 4096 sectors 12287.2MB in 70 cyl groups (89 c/g, 178.00MB/g, 22144 i/g) super-block backups (for fsck -b #) at: 32, 364576, 729120, 1093664, 1458208, 1822752, 2187296, 2551840, 2916384, [...] Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------