From owner-freebsd-threads@FreeBSD.ORG Mon Jan 28 19:43:55 2008 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5613316A469 for ; Mon, 28 Jan 2008 19:43:55 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outO.internet-mail-service.net (outO.internet-mail-service.net [216.240.47.238]) by mx1.freebsd.org (Postfix) with ESMTP id 39E1113C4D9 for ; Mon, 28 Jan 2008 19:43:55 +0000 (UTC) (envelope-from julian@elischer.org) Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160) by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP; Mon, 28 Jan 2008 11:43:54 -0800 Received: from julian-mac.elischer.org (localhost [127.0.0.1]) by idiom.com (Postfix) with ESMTP id B2126127029; Mon, 28 Jan 2008 11:43:53 -0800 (PST) Message-ID: <479E3079.3000803@elischer.org> Date: Mon, 28 Jan 2008 11:43:53 -0800 From: Julian Elischer User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Robert Watson References: <200801240850.m0O8o2JQ023500@freefall.freebsd.org> <4798564B.7070500@elischer.org> <20080128185830.B56811@fledge.watson.org> In-Reply-To: <20080128185830.B56811@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Daniel Eischen , Gary Stanley , freebsd-threads@freebsd.org Subject: Re: threads/119920: fork broken in libpthread X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2008 19:43:55 -0000 Robert Watson wrote: > > On Thu, 24 Jan 2008, Daniel Eischen wrote: > >>> dan what IS the fix for this? I assume you must have fixed it in >>> -current/7 >> >> You want cvs diff -u -r1.126 -r1.128 src/lib/libkse/thread/thr_kern.c. >> The WARNS'ify diffs are not necessary, so it should look something >> like shown below. Probably an MFC of all of libkse (minus jasone's >> malloc changes) should be done to -7 and -6. > > Should the patch be considered for an errata notice for 6.x? Should we > be trying to MFC this to 7.x for inclusion with 7.0 or does it need more > time to shake out and should potentially be a 7.0 errata notice or just > appear in 7.1? > > Robert N M Watson > Computer Laboratory > University of Cambridge yes and yes and no