From owner-cvs-all@FreeBSD.ORG Tue Dec 23 16:05:14 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A8FE16A4CE; Tue, 23 Dec 2003 16:05:14 -0800 (PST) Received: from jkh-gw.brierdr.com (adsl-64-173-3-158.dsl.sntc01.pacbell.net [64.173.3.158]) by mx1.FreeBSD.org (Postfix) with ESMTP id ECE8943D3F; Tue, 23 Dec 2003 16:05:11 -0800 (PST) (envelope-from jkh@queasyweasel.com) Received: from [64.173.15.98] (IDENT:19870-ident-is-a-completely-pointless-protocol-that-offers-no-security-or-traceability-at-all-so-ta@adsl-64-173-15-98.dsl.sntc01.pacbell.net [64.173.15.98]) by jkh-gw.brierdr.com (8.12.10/8.12.10) with ESMTP id hBO04lAi006893; Tue, 23 Dec 2003 16:04:47 -0800 (PST) (envelope-from jkh@queasyweasel.com) In-Reply-To: <20031223134121.GA56900@alaska.cert.siemens.de> References: <200312222045.hBMKjGOr052159@repoman.freebsd.org> <20031223134121.GA56900@alaska.cert.siemens.de> Mime-Version: 1.0 (Apple Message framework v609) Content-Type: multipart/signed; micalg=sha1; boundary=Apple-Mail-6--572172700; protocol="application/pkcs7-signature" Message-Id: From: "Jordan K. Hubbard" Date: Tue, 23 Dec 2003 16:05:07 -0800 To: Udo Schweigert X-Mailer: Apple Mail (2.609) X-Content-Filtered-By: Mailman/MimeDel 2.1.1 cc: "Jordan K. Hubbard" cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/locale ldpart.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Dec 2003 00:05:14 -0000 --Apple-Mail-6--572172700 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed *blink*!! I'll look into this immediately, sorry guys. That's very strange... It's just a straight-up commit of what's in -current. I'll dig into it now and try and fix it, else I'll just back it out. - Jordan On Dec 23, 2003, at 5:41 AM, Udo Schweigert wrote: > On Mon, Dec 22, 2003 at 12:45:16 -0800, Jordan K. Hubbard wrote: >> jkh 2003/12/22 12:45:16 PST >> >> FreeBSD src repository >> >> Modified files: (Branch: RELENG_4) >> lib/libc/locale ldpart.c >> Log: >> MFC: fix memory leak in setlocale() helper functions. >> PR#: misc/59910 >> > > This breaks the libc. > > For example: > > /usr/obj/usr/src/bin/ls/ls > Memory fault (core dumped) > > gdb shows: > #0 0x8067fb3 in __part_load_locale () > (gdb) bt > #0 0x8067fb3 in __part_load_locale () > #1 0x8067e4c in __monetary_load_locale () > #2 0x8057c8a in setlocale () > #3 0x80579e8 in setlocale () > #4 0x8048315 in main () > #5 0x804813e in _start () > > After a buildworld it's the same for all static binaries. > > Best regards > > -- > Udo Schweigert, Siemens AG | Voice : +49 89 636 42170 > CT IC CERT, Siemens CERT | Fax : +49 89 636 41166 > D-81730 Muenchen / Germany | email : udo.schweigert@siemens.com > -- Jordan K. Hubbard Engineering Manager, BSD technology group Apple Computer --Apple-Mail-6--572172700--