From owner-p4-projects@FreeBSD.ORG  Thu Jan  3 23:35:32 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0946616A420; Thu,  3 Jan 2008 23:35:32 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C2CBA16A41A
	for <perforce@freebsd.org>; Thu,  3 Jan 2008 23:35:31 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id B2B5513C448
	for <perforce@freebsd.org>; Thu,  3 Jan 2008 23:35:31 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m03NZV9u073646
	for <perforce@freebsd.org>; Thu, 3 Jan 2008 23:35:31 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m03NZVMf073643
	for perforce@freebsd.org; Thu, 3 Jan 2008 23:35:31 GMT
	(envelope-from jb@freebsd.org)
Date: Thu, 3 Jan 2008 23:35:31 GMT
Message-Id: <200801032335.m03NZVMf073643@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 132441 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jan 2008 23:35:32 -0000

http://perforce.freebsd.org/chv.cgi?CH=132441

Change 132441 by jb@jb_freebsd1 on 2008/01/03 23:34:46

	Add a hack to report if an attempt is being made to free a NULL pointer.
	I am so sick of seeing the DTrace kernel module do that before I've got
	it re-ported.

Affected files ...

.. //depot/projects/dtrace/src/sys/compat/opensolaris/kern/opensolaris_kmem.c#4 edit

Differences ...

==== //depot/projects/dtrace/src/sys/compat/opensolaris/kern/opensolaris_kmem.c#4 (text+ko) ====

@@ -95,6 +95,10 @@
 zfs_kmem_free(void *buf, size_t size __unused)
 {
 #ifdef KMEM_DEBUG
+	if (buf == NULL) {
+		printf("%s: attempt to free NULL\n",__func__);
+		return;
+	}
 	struct kmem_item *i;
 
 	buf = (u_char *)buf - sizeof(struct kmem_item);