From owner-cvs-src@FreeBSD.ORG Thu Apr 24 13:36:53 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52BDA37B414; Thu, 24 Apr 2003 13:36:53 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2937943FA3; Thu, 24 Apr 2003 13:36:51 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h3OKakZW063268; Thu, 24 Apr 2003 13:36:50 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h3OKajcv063267; Thu, 24 Apr 2003 13:36:45 -0700 (PDT) Date: Thu, 24 Apr 2003 13:36:44 -0700 From: "David O'Brien" To: Tim Robbins Message-ID: <20030424203644.GA63208@dragon.nuxi.com> References: <200304240816.h3O8G7U9072127@repoman.freebsd.org> <20030424191557.A63073@dilbert.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030424191557.A63073@dilbert.robbins.dropbear.id.au> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_mount.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.ORG List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Apr 2003 20:36:54 -0000 On Thu, Apr 24, 2003 at 07:15:57PM +1000, Tim Robbins wrote: > On Thu, Apr 24, 2003 at 01:16:07AM -0700, Tim J. Robbins wrote: > > > tjr 2003/04/24 01:16:07 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/kern vfs_mount.c > > Log: > > Free mount credentials (mnt_cred) when freeing the mount struct > > in failure cases to avoid leaking struct ucreds, and ultimately > > leaking struct uidinfo references. > > Here's the full log message, which explains the implications of the uidinfo > refcount leak. > > //depot/user/tjr/freebsd-tjr/src/sys/kern/vfs_mount.c > ... #3 change 29586 edit on 2003/04/23 by tjr@tjr_dev (text+ko) > > Free mount credentials (mnt_cred) when freeing the mount struct > in failures cases to avoid leaking struct ucreds, and ultimately > leaking struct uidinfo references. > > Since the uidinfo reference count was only a "u_short" until a few > days ago, this leak could quite easily have caused an overflow after > a few thousand failed mount attempts, leading to the struct uidinfo > being freed prematurely and the panics in uifree() that Kris was > seeing on the ports cluster. I'm not sure that this specific cred > leak was causing the problems -- I will look for more. Any reason you didn't put the full log message into CVS? People useing Perforce need to be careful to put the full infomation into CVS also. Also why do people keep following up in email to add information rather than doing a forced commit???