From owner-freebsd-ports-bugs@FreeBSD.ORG Mon May 16 18:00:25 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D8E816A4D0 for ; Mon, 16 May 2005 18:00:25 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C17FC43DA6 for ; Mon, 16 May 2005 18:00:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4GI0Kwc007020 for ; Mon, 16 May 2005 18:00:20 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4GI0KS2007019; Mon, 16 May 2005 18:00:20 GMT (envelope-from gnats) Resent-Date: Mon, 16 May 2005 18:00:20 GMT Resent-Message-Id: <200505161800.j4GI0KS2007019@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CDC9216A4CE for ; Mon, 16 May 2005 17:59:41 +0000 (GMT) Received: from mx1.parodius.com (mx1.parodius.com [64.62.145.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9E04B43D7E for ; Mon, 16 May 2005 17:59:41 +0000 (GMT) (envelope-from jdc@pentarou.parodius.com) Received: from pentarou.parodius.com (localhost [127.0.0.1]) by mx1.parodius.com (8.13.3/8.13.3) with ESMTP id j4GHxZgk099404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 16 May 2005 10:59:35 -0700 (PDT) (envelope-from jdc@pentarou.parodius.com) Received: (from jdc@localhost) by pentarou.parodius.com (8.13.3/8.13.3/Submit) id j4GHxZpM099403; Mon, 16 May 2005 10:59:35 -0700 (PDT) (envelope-from jdc) Message-Id: <200505161759.j4GHxZpM099403@pentarou.parodius.com> Date: Mon, 16 May 2005 10:59:35 -0700 (PDT) From: Jeremy Chadwick To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/81117: net-mgmt/mrtg major bugfix -- rateup generates broken graphs X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jeremy Chadwick List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2005 18:00:25 -0000 >Number: 81117 >Category: ports >Synopsis: net-mgmt/mrtg major bugfix -- rateup generates broken graphs >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon May 16 18:00:20 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 4.11-STABLE i386 >Organization: Parodius Networking >Environment: System: FreeBSD pentarou.parodius.com 4.11-STABLE FreeBSD 4.11-STABLE #0: Thu May 12 04:37:52 PDT 2005 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386 >Description: mrtg 2.12.0 contains broken rateup code, and also generates improper CSS, plus does not "decently" support setups where XSize/YSize are used in mrtg.cfg (the newly-added CSS hard-codes width/height of 500x135, rather than letting the browser figure it out). In the meantime, below is the patch for rateup.c which fixes the problem of graphs being drawn as if "Unscaled" was set. The other few bugs will have to wait, as they're cosmetic, although the XSize/YSize one is quite annoying... All of these problems will be addressed in 2.12.1 says Tobias, as I've been in Email contact with him quite a lot this morning about such problems. >How-To-Repeat: Generate some graphs and see what I mean. :-) >Fix: Add this patch to files/, naturally. This comes from Tobias, BTW. --- src/rateup.c~ 2005-05-16 19:15:06.468444000 +0200 +++ src/rateup.c 2005-05-16 19:15:09.138421000 +0200 @@ -318,6 +318,7 @@ } /* multiplicator for bits/bytes */ + maxv = (long long) max (maxvi, maxvo); maxvi = maxvi < (long long) 0 ? -maxvi : maxvi; maxvo = maxvo < (long long) 0 ? -maxvo : maxvo; origmaxvi = maxvi; @@ -328,7 +329,6 @@ maxvi *= muli; maxvo *= muli; } - maxv = (long long) max (maxvi, maxvo); if (step > MONTH_SAMPLE) { type = 4; >Release-Note: >Audit-Trail: >Unformatted: