From owner-p4-projects@FreeBSD.ORG Thu Aug 16 19:09:17 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 1771616A468; Thu, 16 Aug 2007 19:09:17 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C9F7A16A41A for ; Thu, 16 Aug 2007 19:09:16 +0000 (UTC) (envelope-from zec@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B8A2B13C49D for ; Thu, 16 Aug 2007 19:09:16 +0000 (UTC) (envelope-from zec@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7GJ9GVO008918 for ; Thu, 16 Aug 2007 19:09:16 GMT (envelope-from zec@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7GJ9GFB008915 for perforce@freebsd.org; Thu, 16 Aug 2007 19:09:16 GMT (envelope-from zec@FreeBSD.org) Date: Thu, 16 Aug 2007 19:09:16 GMT Message-Id: <200708161909.l7GJ9GFB008915@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to zec@FreeBSD.org using -f From: Marko Zec To: Perforce Change Reviews Cc: Subject: PERFORCE change 125229 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2007 19:09:17 -0000 http://perforce.freebsd.org/chv.cgi?CH=125229 Change 125229 by zec@zec_tca51 on 2007/08/16 19:08:27 Remove a debugging printf() in VNET_LIST_LOCK() that was triggered when acquisition of the exclusive access didn't succeed immediately. Resolving of this condition seems to work fine use the condvar signalling from the thread releasing the shared lock, hence trim down the debugging noise. Affected files ... .. //depot/projects/vimage/src/sys/kern/kern_vimage.c#35 edit Differences ... ==== //depot/projects/vimage/src/sys/kern/kern_vimage.c#35 (text+ko) ==== @@ -115,11 +115,8 @@ #define VNET_LIST_LOCK() \ mtx_lock(&vnet_list_refc_mtx); \ - while (vnet_list_refc != 0) { \ - cv_wait(&vnet_list_condvar, &vnet_list_refc_mtx); \ - printf("XXX vnet_list_refc = %d in %s\n", \ - vnet_list_refc, __FUNCTION__); \ - } + while (vnet_list_refc != 0) \ + cv_wait(&vnet_list_condvar, &vnet_list_refc_mtx); #define VNET_LIST_UNLOCK() \ mtx_unlock(&vnet_list_refc_mtx);