From owner-svn-src-stable@FreeBSD.ORG Mon Apr 29 01:35:30 2013 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id BF17AE88 for ; Mon, 29 Apr 2013 01:35:30 +0000 (UTC) (envelope-from peter@wemm.org) Received: from mail-vb0-x233.google.com (mail-vb0-x233.google.com [IPv6:2607:f8b0:400c:c02::233]) by mx1.freebsd.org (Postfix) with ESMTP id 7E4D51E65 for ; Mon, 29 Apr 2013 01:35:30 +0000 (UTC) Received: by mail-vb0-f51.google.com with SMTP id x19so4911620vbf.10 for ; Sun, 28 Apr 2013 18:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=google; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=QhpKI9EI3Xtqy3fAEd4KiUyWcwflazCJ7kdAzDBDXLE=; b=MS8NqpayjPYH71Z9wwqCOZPJlLFxTCao2c5/50QibUy+Levr2tL3TVohfZrf4x9hUH ftE3jqrPFYznp72o5+8ySRSzTOFdOqAg333R1LLFDul0znI686VXaL0ulkwN7ysLFmXd kldkgCl5LOxuYYjGaac9Wz6SXdIyUhQ8bjjTM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=QhpKI9EI3Xtqy3fAEd4KiUyWcwflazCJ7kdAzDBDXLE=; b=YZ4qqZnbO5YFwM1rIuwReEgHLXYnvdlaWMiO73SXrj9iHhdnx5XFLUwqjcq7sC7qyQ /cfTEIhmu/ksbYoU4fWGRHWYY0libZEIkV77KbWnMBafnChSXGikaHH8zg4N6bXc1XYF FcW3BXVpPerYL04NFcHU/NZjuEipn4NzGq6i2qAc8F7ckhCCAC/FdnZWFuxAfFKyVjvn hCFLaIq0xPEyTdUJeZPlls1DTjbJBwn0kj7jry+Cscy78QXyis/EVLa4dxkZIPtb6COJ 6UGoN3yh8cWKxRLGhmfC5G9tMcMyZLqjmaAuWsqF1KhhexyY8/iIS9BNfeMgQwnD1eFS LQJg== MIME-Version: 1.0 X-Received: by 10.220.169.78 with SMTP id x14mr17435796vcy.41.1367198961184; Sun, 28 Apr 2013 18:29:21 -0700 (PDT) Received: by 10.220.215.70 with HTTP; Sun, 28 Apr 2013 18:29:21 -0700 (PDT) In-Reply-To: References: <201304180944.r3I9i05t093967@svn.freebsd.org> <517AC0BB.4040207@FreeBSD.org> Date: Sun, 28 Apr 2013 18:29:21 -0700 Message-ID: Subject: Re: svn commit: r249611 - in stable/9/sys/cam: ata scsi From: Peter Wemm To: Alexander Motin Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnBraEaW+84mIXQPMRB5cbBm2yNEzDSyylPmDx3MCDs+qtWX6/X0kkEP0x7WL+M922V7voU Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Apr 2013 01:35:30 -0000 On Sat, Apr 27, 2013 at 5:56 PM, Peter Wemm wrote: > On Fri, Apr 26, 2013 at 11:00 AM, Alexander Motin wrote: >> On 26.04.2013 19:47, Peter Wemm wrote: >>> >>> On Thu, Apr 18, 2013 at 2:44 AM, Alexander Motin wrote: >>>> >>>> Author: mav >>>> Date: Thu Apr 18 09:44:00 2013 >>>> New Revision: 249611 >>>> URL: http://svnweb.freebsd.org/changeset/base/249611 > [..] >>> This breaks a number of machines in the freebsd.org cluster. I have >>> to back out both of these changes to get them to reboot. >> >> >> I've made a search though the base system and found only two drivers >> affected by this change: mpt and hptmv. I've patched both at head r249849 >> and going to merge fix to stable/9 tomorrow unless objected. Have you tried >> that patch instead of reverting? > > I'm testing this on ns1.freebsd.org and ns2.freebsd.org as we speak. > If the cluster goes dark, that's why :) The machines have survived multiple reboots with > r249849. I do wonder if perhaps "post_sync" isn't the ideal name. Perhaps add a "quiesce_hardware" eventhandler chain and make it clear that this is the hook for what things like mpt were doing. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV