From owner-svn-ports-head@freebsd.org Mon Oct 9 17:13:45 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5CCFE36DD9; Mon, 9 Oct 2017 17:13:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5803C7163C; Mon, 9 Oct 2017 17:13:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 3A1021C6D5; Mon, 9 Oct 2017 17:13:00 +0000 (UTC) Date: Mon, 9 Oct 2017 17:13:00 +0000 From: Alexey Dokuchaev To: Joe Marcus Clarke Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r451553 - in head/ports-mgmt/portlint: . src Message-ID: <20171009171300.GA99808@FreeBSD.org> References: <201710081758.v98HwqIe003342@repo.freebsd.org> <98416211-8e18-7d8f-b10d-c295e96fd363@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98416211-8e18-7d8f-b10d-c295e96fd363@freebsd.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 17:13:46 -0000 On Mon, Oct 09, 2017 at 12:40:00PM -0400, Joe Marcus Clarke wrote: > On 10/9/17 12:07, Mathieu Arnold wrote: > > Le 08/10/2017 ?? 19:58, Joe Marcus Clarke a ??crit : > >> New Revision: 451553 > >> URL: https://svnweb.freebsd.org/changeset/ports/451553 > >> > >> Log: > >> Update to 2.17.13. > >> > >> * Do not complain about USE_GITHUB before USES [1] > > > > This is wrong. USES= must always happen before any other USE_* variable. > > This was my thought, but the argument around a "fetch" USE_* versus > other build USE_* made sense. I'm happy to go with consensus here. Right; and the fact that we don't have (or plan to get) `Mk/Uses/github.mk' makes "USES= must always happen before any other USE_*" claim semantically irrelevant in this case. ./danfe