From owner-freebsd-stable@FreeBSD.ORG Tue Feb 17 13:10:20 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7BE210656D9 for ; Tue, 17 Feb 2009 13:10:20 +0000 (UTC) (envelope-from eugene@imedia.ru) Received: from lynx.imedia.ru (lynx.imedia.ru [212.65.64.254]) by mx1.freebsd.org (Postfix) with ESMTP id 4C48C8FC1F for ; Tue, 17 Feb 2009 13:10:19 +0000 (UTC) (envelope-from eugene@imedia.ru) Received: from badger.imedia.ru (root@badger.imedia.ru [172.16.0.13]) by lynx.imedia.ru (8.14.3/8.14.3/TWINS5_LDAP) with ESMTP id n1HCqR5m091521; Tue, 17 Feb 2009 15:52:27 +0300 (MSK) (envelope-from eugene@imedia.ru) Received: from badger.imedia.ru (eugene@localhost [127.0.0.1]) by badger.imedia.ru (8.14.3/8.13.1) with ESMTP id n1HCqRPG037640; Tue, 17 Feb 2009 15:52:27 +0300 (MSK) (envelope-from eugene@imedia.ru) Received: from localhost (localhost [[UNIX: localhost]]) by badger.imedia.ru (8.14.3/8.13.8/Submit) id n1HCqNoH037639; Tue, 17 Feb 2009 15:52:23 +0300 (MSK) (envelope-from eugene@imedia.ru) From: Eugene Mitrofanov Organization: Independent Media Sanoma Magazines To: freebsd-stable@freebsd.org Date: Tue, 17 Feb 2009 15:52:23 +0300 User-Agent: KMail/1.9.10 References: <499981AF.9030204@samsco.org> In-Reply-To: <499981AF.9030204@samsco.org> X-Origin: badger.imedia.ru MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902171552.23287.eugene@imedia.ru> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (lynx.imedia.ru [172.16.0.2]); Tue, 17 Feb 2009 15:52:27 +0300 (MSK) X-Virus-Scanned: ClamAV version 0.94.1-exp, clamav-milter version 0.94.1-exp on lynx.imedia.ru X-Virus-Status: Clean Cc: Subject: Re: HEADS UP: More CAM fixes. X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eugene Mitrofanov List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2009 13:10:21 -0000 7.1-STABLE FreeBSD 7.1-STABLE #3: Tue Feb 17 14:58:42 asr0@pci0:3:3:0: class=0x010400 card=0xc0341044 chip=0xa5111044 rev=0x01 hdr=0x00 vendor = 'Adaptec (Formerly: Distributed Processing Technology (DPT))' device = 'Raptor SmartRAID Controller' class = mass storage subclass = RAID root:# camcontrol tags da0 (pass0:asr0:0:0:0): device openings: 1 --------- 6.2-STABLE FreeBSD 6.2-STABLE #1: Mon Oct 15 16:53:04 asr0@pci3:3:0: class=0x010400 card=0xc0341044 chip=0xa5111044 rev=0x01 hdr=0x00 vendor = 'Adaptec (Formerly: Distributed Processing Technology (DPT))' device = 'Raptor SmartRAID Controller' class = mass storage subclass = RAID root:# camcontrol tags da0 (pass0:asr0:0:0:0): device openings: 255 On Monday 16 February 2009, Scott Long wrote: > FWI. I need lots of testing on this. Only real SCSI controllers, > please, not RAID controllers (except for MPT-SCSI with integrated > mirroring). So Adaptec, LSI, Symbios, Buslogic, Tekram, SME, etc, > users, please try this and get back to me. The patch should apply > to FreeBSD 7 as well. FreeBSD 6 is only affected by this problem > when CAM_NEW_TRAN_CODE is enabled. > > Scott > > > -------- Original Message -------- > Subject: svn commit: r188671 - head/sys/cam > Date: Mon, 16 Feb 2009 14:57:15 +0000 (UTC) > From: Scott Long > To: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, > svn-src-head@FreeBSD.org > > Author: scottl > Date: Mon Feb 16 14:57:15 2009 > New Revision: 188671 > URL: http://svn.freebsd.org/changeset/base/188671 > > Log: > Fix parallel SCSI negotiation in the CAM_NEW_TRAN_CODE world order. > Overzealous sanity checks were locking the sync_rate and offset values to > zero, thanks to a twisty maze of recursive code. > > Modified: > head/sys/cam/cam_xpt.c > > Modified: head/sys/cam/cam_xpt.c > ============================================================================== > --- head/sys/cam/cam_xpt.c Mon Feb 16 14:38:52 2009 (r188670) > +++ head/sys/cam/cam_xpt.c Mon Feb 16 14:57:15 2009 (r188671) > @@ -6679,9 +6679,7 @@ xpt_set_transfer_settings(struct ccb_tra > if (((device->flags & CAM_DEV_INQUIRY_DATA_VALID) != 0 > && (inq_data->flags & SID_Sync) == 0 > && cts->type == CTS_TYPE_CURRENT_SETTINGS) > - || ((cpi.hba_inquiry & PI_SDTR_ABLE) == 0) > - || (spi->sync_offset == 0) > - || (spi->sync_period == 0)) { > + || ((cpi.hba_inquiry & PI_SDTR_ABLE) == 0)) { > /* Force async */ > spi->sync_period = 0; > spi->sync_offset = 0; > @@ -6729,7 +6727,8 @@ xpt_set_transfer_settings(struct ccb_tra > if (spi->bus_width == 0) > spi->ppr_options = 0; > > - if ((spi->flags & CTS_SPI_FLAGS_DISC_ENB) == 0) { > + if ((spi->valid & CTS_SPI_VALID_DISC) > + && ((spi->flags & CTS_SPI_FLAGS_DISC_ENB) == 0)) { > /* > * Can't tag queue without disconnection. > */ > _______________________________________________ > freebsd-stable@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org" > > -- EMIT-RIPN, EVM7-RIPE