From owner-freebsd-bugs  Thu Dec 13 10:40: 6 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id B7ACE37B417
	for <freebsd-bugs@hub.freebsd.org>; Thu, 13 Dec 2001 10:40:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id fBDIe1u40426;
	Thu, 13 Dec 2001 10:40:01 -0800 (PST)
	(envelope-from gnats)
Date: Thu, 13 Dec 2001 10:40:01 -0800 (PST)
Message-Id: <200112131840.fBDIe1u40426@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Evan Sarmiento <evms@cs.bu.edu>
Subject: Re: misc/32680: [PATCH] Allows users to start jails by hostname as well as IP address
Reply-To: Evan Sarmiento <evms@cs.bu.edu>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR misc/32680; it has been noted by GNATS.

From: Evan Sarmiento <evms@cs.bu.edu>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: misc/32680: [PATCH] Allows users to start jails by hostname as well as IP address
Date: Thu, 13 Dec 2001 13:32:49 -0500 (EST)

 Finally, I fixed it, and it should all be fine now:
 
 --- jail.c	Thu Dec 13 11:24:04 2001
 +++ jail.new	Thu Dec 13 11:25:43 2001
 @@ -17,20 +17,20 @@
  #include <arpa/inet.h>
  
  #include <err.h>
 -#include <stdio.h>
 +#include <netdb.h>
  #include <stdlib.h>
 -#include <string.h>
  #include <unistd.h>
  
  int
  main(int argc, char **argv)
  {
 +	struct hostent *hp;
  	struct jail j;
  	int i;
  	struct in_addr in;
  
  	if (argc < 5) 
 -		errx(1, "Usage: %s path hostname ip-number command ...\n",
 +		errx(1, "Usage: %s path hostname address command ...\n",
  		    argv[0]);
  	i = chdir(argv[1]);
  	if (i)
 @@ -40,8 +40,18 @@
  	j.path = argv[1];
  	j.hostname = argv[2];
  	i = inet_aton(argv[3], &in);
 -	if (!i)
 -		errx(1, "Couldn't make sense of ip-number\n");
 +
 +	if (i == NULL) {
 +	        hp = gethostbyname(argv[3]);
 +
 +	        if (hp == NULL)
 +	            errx(1, "gethostbyname(%s): %s (and) inet_aton(%s): Could not make sense of either IP number or hostname.",
 +                         argv[3], hstrerror(h_errno), argv[3] );
 +
 +	        else if (hp)
 +	                in = *(struct in_addr *)hp->h_addr;
 +        }
 +	
  	j.ip_number = ntohl(in.s_addr);
  	i = jail(&j);
  	if (i)
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message