Date: Thu, 05 Feb 2015 06:52:57 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197234] [UPDATE] lang/execline: update to 2.0.2.0 and take maintainership Message-ID: <bug-197234-13-4n3WKQP27j@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197234-13@https.bugs.freebsd.org/bugzilla/> References: <bug-197234-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197234 --- Comment #4 from Colin Booth <colin@heliocat.net> --- (In reply to Jan Beich from comment #1) >> +LDFLAGS?=3D -s >> +STRIPFLAGS?=3D -x >Better use ${STRIP} or depend on ! ${PORT_OPTIONS:MDEBUG} and maybe use ve= ndor >`strip` make target e.g., > # STRIP can only be `-s` or empty > ALL_TARGET=3D all ${STRIP:S/-s/strip/} Adapted from the old Makefile for skalibs in ports. I'll yank those out bec= ause it doesn't run strip by default anyway.=20 >> +CC?=3D cc >CC is always defined by sys.mk (fmake, bmake) or embedded (gmake). >> +WRKSRC=3D ${WRKDIR}/${DISTNAME} >No need to redefine the default value. You're right on both counts. I thought I'd have to force-define what the default cc pointed to since without specifying CC=3D${CC} the upstream Make= file autodetects a compiler that doesn't support the -i flag. As for WRKSRC, I d= on't know why I didn't think that came included. >> +USES=3D ${GMAKE} >This works only by accident because the path to GNU make isn't an absolute= one. That was on the suggestion of portlint since building execline (and skalibs= and s6) don't work with the stock make and I'm working around a reasonably linux-tools centric design. >Define HAS_CONFIGURE and populate CONFIGURE_ARGS. This would also fix a ca= se where CC contains spaces e.g., Unless I'm reading the porters stuff wrong HAS_CONFIGURE only works with autoconf and its ilk. Since skalibs et. al. don't use autotools I'm going to omit HAS_CONFIGURE (it seems to be ignored). However, that appears to mean = that I need the CC=3D${CC} definition which breaks if there's a multiple item CC definition. If I find out a better way to override this, I'll fix it. >do-build... >do-install... >use post-install... All good suggestions and updated.=20 >> +lib/libexecline.so >> +lib/libexecline.so.2 >This requires USE_LDCONFIG in Makefile. Missed that in the port handbook. Updated. >> + --prefix=3D${LOCALBASE} \ >This would break install if PREFIX !=3D LOCALBASE i.e., poudriere testport= -P. >You may need to pass --with-sysdeps as well to unbreak it. Changed all LOCALBASE to PREFIX though that's still going to break if skali= bs isn't going to be installed in the same root tree since execline needs to f= ind the skalibs headers and I'm unaware of a good way of autodetecting that.=20 Related to that, I've debated whether to static link libskarnet into the execline binaries. On the one hand dynamic linking is the standard, on the other it's nice to have the only external runtime dependency be your libc f= or things like proces supervisors. Since there's already a compile-time depend= ency on skalibs being installed in the same PREFIX as execline I'm going to leav= e it the default (static linking) unless there's a serious argument in the other direction. Thanks for the commentary and advice, the skarnet stuff is my first foray i= nto porting so I'm sure I'll make mistakes along the way. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197234-13-4n3WKQP27j>