From owner-cvs-src@FreeBSD.ORG  Fri Jul  2 03:17:45 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6620C16A4FB; Fri,  2 Jul 2004 03:17:45 +0000 (GMT)
Received: from VARK.homeunix.com (adsl-69-107-104-105.dsl.pltn13.pacbell.net
	[69.107.104.105])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2AAB343D53; Fri,  2 Jul 2004 03:17:45 +0000 (GMT)
	(envelope-from das@FreeBSD.ORG)
Received: from VARK.homeunix.com (localhost [127.0.0.1])
	by VARK.homeunix.com (8.12.11/8.12.10) with ESMTP id i623GIBT080842;
	Thu, 1 Jul 2004 20:16:18 -0700 (PDT)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.homeunix.com (8.12.11/8.12.10/Submit) id i623GIrv080841;
	Thu, 1 Jul 2004 20:16:18 -0700 (PDT)
	(envelope-from das@FreeBSD.ORG)
Date: Thu, 1 Jul 2004 20:16:18 -0700
From: David Schultz <das@FreeBSD.ORG>
To: "Christian S.J. Peron" <csjp@FreeBSD.ORG>
Message-ID: <20040702031618.GA80812@VARK.homeunix.com>
Mail-Followup-To: "Christian S.J. Peron" <csjp@FreeBSD.ORG>,
	src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200406301858.i5UIwJkB047720@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200406301858.i5UIwJkB047720@repoman.freebsd.org>
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/libexec/tftpd tftpd.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Jul 2004 03:17:45 -0000

On Wed, Jun 30, 2004, Christian S.J. Peron wrote:
> csjp        2004-06-30 18:58:19 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     libexec/tftpd        tftpd.c 
>   Log:
>   The call to setuid(2) subsequently causes setgroups(2) to fail. setgroups(2)
>   requires super-user access in order to complete successfully.
>   Move setgroups(2) to execute before setuid(2) so that it is successful.

Error checks would also be appropriate here, and would have
caught the bug.