From owner-freebsd-hackers  Sun Feb 25 23:29: 2 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from freebsd.dk (freebsd.dk [212.242.42.178])
	by hub.freebsd.org (Postfix) with ESMTP id E961D37B503
	for <freebsd-hackers@freebsd.org>; Sun, 25 Feb 2001 23:28:59 -0800 (PST)
	(envelope-from sos@freebsd.dk)
Received: (from sos@localhost)
	by freebsd.dk (8.9.3/8.9.1) id IAA43029;
	Mon, 26 Feb 2001 08:28:56 +0100 (CET)
	(envelope-from sos)
From: Soren Schmidt <sos@freebsd.dk>
Message-Id: <200102260728.IAA43029@freebsd.dk>
Subject: Re: ata-disk ioctl and atactl patch
In-Reply-To: <20010225194120.A64003@bonsai.home.renfro.org> from Scott Renfro at "Feb 25, 2001 07:41:20 pm"
To: scott@renfro.org (Scott Renfro)
Date: Mon, 26 Feb 2001 08:28:56 +0100 (CET)
Cc: freebsd-hackers@freebsd.org, raj@cisco.com (Richard Johnson)
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

It seems Scott Renfro wrote:
> As I promised on -mobile earlier this week, I've cleaned up my patches
> to port the {Net,Open}BSD atactl utility, including a simplistic
> ata-disk ioctl.  They apply cleanly against this afternoon's -stable
> (including Soren's latest commit bringing -stable up to date with
> -current).  I've been running them for some time and they ''work great
> here''.
> 
> Before announcing this in a broader context, I wanted to get a bit of
> feedback on the ioctl implementation.  In particular, is it safe to
> just do an ata_command inside adioctl() without any further checking?
> (e.g., can this cause bad things to happen under heavy i/o load?)

No its not safe at all, you risk trashing an already running command...

Anyhow, I have an atacontrol thingy in the works for attach/detach,
raid control etc, etc, I'll try to merge this functionality into that
(the ioctl's will change etc, but the functionality is nice)...

-Søren

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message