Date: Tue, 10 Sep 2013 19:10:18 +0300 From: Ivan Klymenko <fidaj@ukr.net> To: "O. Hartmann" <ohartman@zedat.fu-berlin.de> Cc: FreeBSD Ports <freebsd-ports@freebsd.org>, John Hein <jhein@symmetricom.com> Subject: Re: HELP! nvidia-driver patch: Weird REPLACE_CMD and command-line-sed behaviour. HELP! Message-ID: <20130910191018.4c8b1eff@nonamehost.local> In-Reply-To: <20130910175544.3feb9029@thor.walstatt.dyndns.org> References: <20130910015144.41c88d52@thor.walstatt.dyndns.org> <21039.10674.968260.7845@gromit.timing.com> <20130910162616.6ce1d52f@thor.walstatt.dyndns.org> <21039.16301.572328.142329@gromit.timing.com> <20130910175544.3feb9029@thor.walstatt.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
=D0=92 Tue, 10 Sep 2013 17:55:44 +0200
"O. Hartmann" <ohartman@zedat.fu-berlin.de> =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> On Tue, 10 Sep 2013 09:50:05 -0600
> John Hein <jhein@symmetricom.com> wrote:
>=20
> > O. Hartmann wrote at 16:26 +0200 on Sep 10, 2013:
> > > On Tue, 10 Sep 2013 08:16:18 -0600
> > > John Hein <jhein@symmetricom.com> wrote:
> > > > You want to use $$/ instead of $/ :
> > > >
> > > > .if ${OSVERSION} > 1000053
> > > > ${REINPLACE_CMD} -e 's/\(\&virtual_address, size,\) \
> > > > \(VMFS_ANY_SPACE,\)$$/\1 0, \2/' \
> > > > \ ${WRKSRC}/src/nvidia_subr.c
> > > > .endif
> > >
> > > if things are understood, there s nothing scaring. Thanks, I
> > > didn't realize that even the expression inside '' is eavluated
> > > by make.
> > >
> > > Thanks to you I could provide the patch to my PR. Hopefuilly,
> > > there is a committer soon.
> >=20
> > Actually I should have said you want:
> >=20
> > .if ${OSVERSION} > 1000055
> >=20
> > The API change to vm_map_find was made between shortly before
> > 1000055.
>=20
>=20
> I'm on FreeBSD 10.0-CURRENT #1 r255434: Tue Sep 10 02:01:02 CEST 2013
> amd64 and when calling=20
>=20
> make -VOSVERSION in x11/nvidia-driver I receive
>=20
> 1000054
yes, unfortunately, make a bump FreeBSD version after this revision
http://svnweb.freebsd.org/changeset/base/255449
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130910191018.4c8b1eff>