Date: Tue, 07 Feb 2012 17:02:55 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: erdgeist@erdgeist.org Cc: freebsd-rc@FreeBSD.org Subject: Re: Proposal ipv6_addrs_common Message-ID: <20120207.170255.161251905285915806.hrs@allbsd.org> In-Reply-To: <4F3088C8.9090505@erdgeist.org> References: <4F304F54.4020802@FreeBSD.org> <20120207.072925.1861639312875773760.hrs@allbsd.org> <4F3088C8.9090505@erdgeist.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Tue_Feb__7_17_02_55_2012_310)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Dirk Engling <erdgeist@erdgeist.org> wrote
in <4F3088C8.9090505@erdgeist.org>:
er> - From my understanding all that's to do is to match the ifconfig
er> parameter syntax and expand ip addresses. There's several ways to do that.
er>
er> You can just accept them as positional paramters in a function, and
er> then shift them out one by one, matching inet and inet6, switching
er> state and returning an expanded string to be executed by the caller.
er>
er> You can also match
er>
er> [ ${foo#inet} = ${foo} ] || foo=`expand_ipv4 ${foo}`
er>
er> or
er>
er> case ${foo} in "inet *") ... ; case "inet6 *") ;;
Ah, I see. This looks good. I will give it a try and investigate
corner cases.
er> to do the actual work. What exactly is the newline for in that case?
er> To make it clearer where single invocations of ifconfig need to be
er> separated?
er>
er> There is no need to introduce any split characters, as inet and inet6
er> by themself act as such. In fact, they're not even needed as from the
er> parameter itself the address family should become clear. I never
er> understood why the code insist so heavily on the user to specify the
er> inet and inet6 keywords. Any particular reason?
This is because it is unclear that which address family will be used
to recognize an address without AF keyword. In most cases
network-related utilities/scripts assume IPv4 by default and require
a modifier or option for the others. It works, but sometimes it
requires a complex and inconsistent address handling in
utilities/scripts. Appending AF keyword burdens users a bit but
simplifies multiple address family support in more consistent manner.
-- Hiroki
----Security_Multipart(Tue_Feb__7_17_02_55_2012_310)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iEYEABECAAYFAk8w2q8ACgkQTyzT2CeTzy0jawCgjOqNhzK2ew7kjUbm42KCdJGA
MdUAoJM8WLQ5/Pk/Ysu1LScDMOX2ynGJ
=L1Gh
-----END PGP SIGNATURE-----
----Security_Multipart(Tue_Feb__7_17_02_55_2012_310)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120207.170255.161251905285915806.hrs>