From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jan 15 16:20:03 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 458F616A475 for ; Tue, 15 Jan 2008 16:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2A84013C4D5 for ; Tue, 15 Jan 2008 16:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0FGK2pG090497 for ; Tue, 15 Jan 2008 16:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0FGK2V0090496; Tue, 15 Jan 2008 16:20:02 GMT (envelope-from gnats) Resent-Date: Tue, 15 Jan 2008 16:20:02 GMT Resent-Message-Id: <200801151620.m0FGK2V0090496@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Naram Qashat Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 448E316A418 for ; Tue, 15 Jan 2008 16:14:27 +0000 (UTC) (envelope-from root@cyberbotx.com) Received: from QMTA06.westchester.pa.mail.comcast.net (qmta06.westchester.pa.mail.comcast.net [76.96.62.56]) by mx1.freebsd.org (Postfix) with ESMTP id E9E1313C4DD for ; Tue, 15 Jan 2008 16:14:26 +0000 (UTC) (envelope-from root@cyberbotx.com) Received: from OMTA10.westchester.pa.mail.comcast.net ([76.96.62.28]) by QMTA06.westchester.pa.mail.comcast.net with comcast id dU351Y0070cZkys0502t00; Tue, 15 Jan 2008 16:14:25 +0000 Received: from kirby.cyberbotx.com ([68.43.195.82]) by OMTA10.westchester.pa.mail.comcast.net with comcast id dUE21Y00C1n8LeU3W00000; Tue, 15 Jan 2008 16:14:03 +0000 Received: by kirby.cyberbotx.com (Postfix, from userid 0) id D43F7C13C; Tue, 15 Jan 2008 11:14:23 -0500 (EST) Message-Id: <20080115161423.D43F7C13C@kirby.cyberbotx.com> Date: Tue, 15 Jan 2008 11:14:23 -0500 (EST) From: Naram Qashat To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: lev@FreeBSD.org Subject: ports/119688: [PATCH] devel/mingw32-binutils: Correct ld build problem X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2008 16:20:03 -0000 >Number: 119688 >Category: ports >Synopsis: [PATCH] devel/mingw32-binutils: Correct ld build problem >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Jan 15 16:20:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Naram Qashat >Release: FreeBSD 6.2-RELEASE-p8 i386 >Organization: >Environment: System: FreeBSD kirby.cyberbotx.com 6.2-RELEASE-p8 FreeBSD 6.2-RELEASE-p8 #12: Sun Oct 14 16:14:35 EDT 2007 >Description: When mingw32-binutils got to the genscripts.sh part of building ld, it would fail with the message: .././ld/genscripts.sh: 403: Syntax error: Bad substitution I couldn't find the exact reason for this, but it was in a section specific to bash syntax and not sh syntax. Removing the bash portion allows the script to complete with no issues. Note: I do have bash installed, but my /bin/sh is not bash. So I am still at a loss for why it would run the bash section of the script. Note 2: I didn't bump PORTREVISION because this is a minor change. Added file(s): - files/patch-ld-genscripts.sh Port maintainer (lev@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: >Fix: --- mingw32-binutils-2.18,1.patch begins here --- diff -ruN --exclude=CVS /usr/ports/devel/mingw32-binutils/files/patch-ld-genscripts.sh /kirby/shared/ports/mingw32-binutils/files/patch-ld-genscripts.sh --- /usr/ports/devel/mingw32-binutils/files/patch-ld-genscripts.sh Wed Dec 31 19:00:00 1969 +++ /kirby/shared/ports/mingw32-binutils/files/patch-ld-genscripts.sh Tue Jan 15 11:05:52 2008 @@ -0,0 +1,41 @@ +--- ld/genscripts.sh.orig Sun Aug 12 15:00:07 2007 ++++ ld/genscripts.sh Tue Jan 15 11:04:56 2008 +@@ -390,30 +390,14 @@ + *" ${EMULATION_NAME} "*) COMPILE_IN=true;; + esac + +-if test -n "${BASH+set}"; then +- source_em() +- { +- local current_script="$em_script" +- em_script=$1 +- . $em_script +- em_script=$current_script +- } +- fragment() +- { +- local lineno=$[${BASH_LINENO[0]} + 1] +- echo >> e${EMULATION_NAME}.c "#line $lineno \"$em_script\"" +- cat >> e${EMULATION_NAME}.c +- } +-else +- source_em() +- { +- . $1 +- } +- fragment() +- { +- cat >> e${EMULATION_NAME}.c +- } +-fi ++source_em() ++{ ++ . $1 ++} ++fragment() ++{ ++ cat >> e${EMULATION_NAME}.c ++} + + # Generate e${EMULATION_NAME}.c. + # Start with an empty file, then the sourced .em script --- mingw32-binutils-2.18,1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: