From nobody Tue Jun 23 15:51:53 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gl8hB0Lznz6hdFT for ; Tue, 23 Jun 2026 15:51:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gl8h94vn4z3DqP for ; Tue, 23 Jun 2026 15:51:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782229913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XVxQjc68u0vXkP7keOM2KNPoecY7TkdwJL72tUFvxFE=; b=yGfVAsbUa4i/4yk5eEglcflBScVq5i/meJy1a9BeuehJg1BIVLV3Py24BiUKmyioDZOCX1 BrMZhq54y6Had6bVYtq6ruyoNnid+YOezKkKVaxBSkNRse5f60xfrwBHypFOKDjSx8be/b /+0/ZK7ssgOP/scyFHvJ1zY+tABayi3BCYGWpREswCR/4nPdGlzjZhHAbr74jXpWLTS9Lw +EheyIFFMuWjoJdEoeYvql7Ziy3+1qrQgZz90iQnE2y/G3bx86AcEL0yFg3i7AkxlpmcAw 4Jaw4ZulaIz97/mJzDdDmpDakmhLiM14Ats02uQ81FaMxK4pd6i3A6Ft9jM9rw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782229913; a=rsa-sha256; cv=none; b=lp4QKqtMa08nNFHPQs0TnGOsqMN1WKpUkeE//IQY6tBfHaqyaxhaEH2ycZjX5BJ9EuQxba 9v7UzV7li3exlJsFJP46fy+8SlPbemBC5tCjzrcGOmNZJIIEFtGBDHCOJfOMbv4DXHhw18 qndIXc63B9nznL7Xzl+mGw7gxGEj/TioaW/d0OKne6aceZ7BZ78f7ZO7e7Lsa3ues/8/xa +7BJygARt9pGRlEb6k1PwW/ReUbYaYgUmIm/4SL0ql+hLIw8SlDK8j8Bn4/IgJU+ToQDUW pg2XSzAIxKmq+nRW6jkW2RQAOnkJ9oLbKah/sSr+Ot4yfbl37Hg8Z/4EgKmOWA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782229913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XVxQjc68u0vXkP7keOM2KNPoecY7TkdwJL72tUFvxFE=; b=IYcR0zDY4gETYnlApmipPVoDrQty3c5EVi8QMXEMCvV4fwHUWfU7V0vK5OyqiFfNu5tnlW x/JyAMfY4wqYTGc1qShuCJ8Yv4Cu7FIwSkn6A2syzFMkoExfgIcV/3+yR5Nlrd4PAChbVn Uh7KrzMyTpfI1WQPFazIxfy5R1lQlQAj1+kN/LC6E/hDen7DycWljVKrzV5DZSuxHOZjou WhDP+R9u3NUiBPjyBFB34JiKrQjYF6QAwRkJkWfAL8vEhlH9EZdEHaS1fTfLlHrth3JUXB FdJwzfcgN/cTOMlGUmjPZkvroGpIj5moIepiO9wAc6vmJrEBemZQdLQji+lo4w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gl8h93Yf9zgtc for ; Tue, 23 Jun 2026 15:51:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 238a4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 23 Jun 2026 15:51:53 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 3d945604ef8e - main - cd9660: Add support for birth times List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3d945604ef8e1aaa49e153d82821fb4c6c1e67f2 Auto-Submitted: auto-generated Date: Tue, 23 Jun 2026 15:51:53 +0000 Message-Id: <6a3aab99.238a4.5bf7d1ae@gitrepo.freebsd.org> The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=3d945604ef8e1aaa49e153d82821fb4c6c1e67f2 commit 3d945604ef8e1aaa49e153d82821fb4c6c1e67f2 Author: John Baldwin AuthorDate: 2026-06-23 15:51:43 +0000 Commit: John Baldwin CommitDate: 2026-06-23 15:51:43 +0000 cd9660: Add support for birth times Both the Extended Attribute Record in the base ISO-9660 standard and the RockRidge timestamp extension support a file creation timestamp. Use this to populate the birthtime if present. Reviewed by: markj (earlier version) Differential Revision: https://reviews.freebsd.org/D57526 --- sys/fs/cd9660/cd9660_node.c | 12 +++++++----- sys/fs/cd9660/cd9660_node.h | 1 + sys/fs/cd9660/cd9660_rrip.c | 16 ++++++++++++++-- sys/fs/cd9660/cd9660_vnops.c | 1 + 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/sys/fs/cd9660/cd9660_node.c b/sys/fs/cd9660/cd9660_node.c index 747536042ccc..a8b0df832aa4 100644 --- a/sys/fs/cd9660/cd9660_node.c +++ b/sys/fs/cd9660/cd9660_node.c @@ -184,13 +184,14 @@ cd9660_deftstamp(struct iso_directory_record *isodir, struct iso_node *inop, * Only the first two are meaningful for struct * stat. */ - struct timespec birthtime; - - if (!cd9660_tstamp_conv17(ap->ctime, &birthtime)) - memset(&birthtime, 0, sizeof(birthtime)); + if (!cd9660_tstamp_conv17(ap->ctime, + &inop->inode.iso_birthtime)) + memset(&inop->inode.iso_birthtime, 0, + sizeof(inop->inode.iso_birthtime)); if (!cd9660_tstamp_conv17(ap->mtime, &inop->inode.iso_mtime)) - inop->inode.iso_mtime = birthtime; + inop->inode.iso_mtime = + inop->inode.iso_birthtime; inop->inode.iso_ctime = inop->inode.iso_mtime; inop->inode.iso_atime = inop->inode.iso_mtime; } else @@ -200,6 +201,7 @@ cd9660_deftstamp(struct iso_directory_record *isodir, struct iso_node *inop, cd9660_tstamp_conv7(isodir->date,&inop->inode.iso_ctime,ftype); inop->inode.iso_atime = inop->inode.iso_ctime; inop->inode.iso_mtime = inop->inode.iso_ctime; + inop->inode.iso_birthtime = inop->inode.iso_ctime; } if (bp2) brelse(bp2); diff --git a/sys/fs/cd9660/cd9660_node.h b/sys/fs/cd9660/cd9660_node.h index 6021c1681c5d..27e4de2f5594 100644 --- a/sys/fs/cd9660/cd9660_node.h +++ b/sys/fs/cd9660/cd9660_node.h @@ -47,6 +47,7 @@ typedef struct { struct timespec iso_atime; /* time of last access */ struct timespec iso_mtime; /* time of last modification */ struct timespec iso_ctime; /* time file changed */ + struct timespec iso_birthtime; /* time file created */ u_short iso_mode; /* files access mode and type */ uid_t iso_uid; /* owner user id */ gid_t iso_gid; /* owner group id */ diff --git a/sys/fs/cd9660/cd9660_rrip.c b/sys/fs/cd9660/cd9660_rrip.c index e3aab4fa6115..1f956434c642 100644 --- a/sys/fs/cd9660/cd9660_rrip.c +++ b/sys/fs/cd9660/cd9660_rrip.c @@ -376,14 +376,20 @@ cd9660_rrip_tstamp(ISO_RRIP_TSTAMP *p, size_t len, ISO_RRIP_ANALYZE *ana) /* Check a format of time stamp (7bytes/17bytes) */ if (!(*p->flags & ISO_SUSP_TSTAMP_FORM17)) { if (*p->flags & ISO_SUSP_TSTAMP_CREAT) { + cd9660_tstamp_conv7(ptime, + &ana->inop->inode.iso_birthtime, ISO_FTYPE_RRIP); ptime += 7; + } else { + memset(&ana->inop->inode.iso_birthtime, 0, + sizeof(struct timespec)); } if (*p->flags & ISO_SUSP_TSTAMP_MODIFY) { cd9660_tstamp_conv7(ptime, &ana->inop->inode.iso_mtime, ISO_FTYPE_RRIP); ptime += 7; } else { - memset(&ana->inop->inode.iso_mtime, 0, sizeof(struct timespec)); + ana->inop->inode.iso_mtime = + ana->inop->inode.iso_birthtime; } if (*p->flags & ISO_SUSP_TSTAMP_ACCESS) { cd9660_tstamp_conv7(ptime, &ana->inop->inode.iso_atime, @@ -400,13 +406,19 @@ cd9660_rrip_tstamp(ISO_RRIP_TSTAMP *p, size_t len, ISO_RRIP_ANALYZE *ana) } } else { if (*p->flags & ISO_SUSP_TSTAMP_CREAT) { + cd9660_tstamp_conv17(ptime, + &ana->inop->inode.iso_birthtime); ptime += 17; + } else { + memset(&ana->inop->inode.iso_birthtime, 0, + sizeof(struct timespec)); } if (*p->flags & ISO_SUSP_TSTAMP_MODIFY) { cd9660_tstamp_conv17(ptime, &ana->inop->inode.iso_mtime); ptime += 17; } else { - memset(&ana->inop->inode.iso_mtime, 0, sizeof(struct timespec)); + ana->inop->inode.iso_mtime = + ana->inop->inode.iso_birthtime; } if (*p->flags & ISO_SUSP_TSTAMP_ACCESS) { cd9660_tstamp_conv17(ptime, &ana->inop->inode.iso_atime); diff --git a/sys/fs/cd9660/cd9660_vnops.c b/sys/fs/cd9660/cd9660_vnops.c index 92ea6d2b4501..579844e941aa 100644 --- a/sys/fs/cd9660/cd9660_vnops.c +++ b/sys/fs/cd9660/cd9660_vnops.c @@ -191,6 +191,7 @@ cd9660_getattr(struct vop_getattr_args *ap) vap->va_atime = ip->inode.iso_atime; vap->va_mtime = ip->inode.iso_mtime; vap->va_ctime = ip->inode.iso_ctime; + vap->va_birthtime = ip->inode.iso_birthtime; vap->va_rdev = VN_ISDEV(vp) ? ip->inode.iso_rdev : NODEV; vap->va_size = ip->i_size;