Date: Wed, 15 Aug 2018 09:49:24 +0000 From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 230619] pf: tables use non SMP-friendly counters Message-ID: <bug-230619-16861-d0ySpR6xWq@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230619-16861@https.bugs.freebsd.org/bugzilla/> References: <bug-230619-16861@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230619 Andrey V. Elsukov <ae@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ae@FreeBSD.org --- Comment #1 from Andrey V. Elsukov <ae@FreeBSD.org> --- It seems you don't check the result of counter allocation, that with M_NOWAIT can fail. And then you are doing an access to such pointers. I'm not familiar with PF, but what happens if you try to limit UMA zone used for these counters and try to create enough number of entries? I suspect it will just panic. Also, PCPU counters are very expensive memory consumers, on modern machines with tens CPU cores, they require a lot of memory. And tables usually used to keep large number of entries, at least for ipfw. Is it really needed feature for PF for such cost? -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230619-16861-d0ySpR6xWq>