From owner-svn-src-head@freebsd.org Wed May 3 20:31:46 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2D42D5CBAD for ; Wed, 3 May 2017 20:31:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A8634EBD for ; Wed, 3 May 2017 20:31:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x233.google.com with SMTP id e65so772579ita.1 for ; Wed, 03 May 2017 13:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=pmcEeKj1c4PRTXGiXe3qEaGINRBM29e6qdkc8TZME7E=; b=pdlfm/oagej9rjQryQkJqffmzpS6PktFsNXx+q2Z62yIwaByXT5WOuyaC59cZCg6Tg raBi+Tw8JY342t+jX6QMcTXonaQgYXsqx/sl0QCeeWsKh1HaIjogP4jXFtwekIdatPvD fKgd4zAVoIncedzB/mAtbQjutXMvDlF3QIOhMrQ0aNBWWD3/eWQYqzrfc1d0v3rzKjoi YW/ymLbebQXJVbmRUWtR2mr2WaJ63axvCuS3wffXc7Fpzawb+xmTF+375PRt7UX2wLG9 /GYgbdLSc5RdCqOyODNGHMZSi8ZafuKrkl5AeXTcTKnIGmvSGHi5729PG616hGSp3MgQ DW8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=pmcEeKj1c4PRTXGiXe3qEaGINRBM29e6qdkc8TZME7E=; b=HAdkxUMlCa8C0thIAvkEFEB0EkVUidb+y/2jiZpIoeLgh63DzyelSHOjfynEf5AaOk mz90Vhkn5vzLabBY3FmDOLQfdRPlFfq/0HdAgo/BaSpjKo60lWlKzLZR2k+I3tGlyw8M KB0ZNAeqaAcFv/E/3Gc2shUxDkdNfaUkIcSlUJVPy3S438UXX7/58NRgNZ0xfO309P85 q2KVV1Y8rtk7TZt0LlEmu6K8zj84kUjeSpB9PXG2ykTBysxjpBCJPrjcxw0Y099bRDz9 DTZ+AzoTpVt5rJSmbzhEDqaj4tHb1RPRux2mfg1D17WL1tfUNfpTtTuHERPukYTL3Xn6 NtkA== X-Gm-Message-State: AN3rC/7LcuFfPY1gZ+15RRzulGtajrYhyIHI7cfJPO8xYarZZRiEILEc TCIrtw5gKKhMGu3/nfKdo/fSlIlG9w== X-Received: by 10.36.181.1 with SMTP id v1mr10744143ite.103.1493843505726; Wed, 03 May 2017 13:31:45 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.126.6 with HTTP; Wed, 3 May 2017 13:31:45 -0700 (PDT) X-Originating-IP: [2607:fb10:7021:1::44a] In-Reply-To: References: <201705031721.v43HL2vS071819@repo.freebsd.org> <8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD@gmail.com> From: Warner Losh Date: Wed, 3 May 2017 14:31:45 -0600 X-Google-Sender-Auth: AoYcJAWAzhBmDpbODgfisK1Mi0I Message-ID: Subject: Re: svn commit: r317755 - head/sbin/ifconfig To: Alan Somers Cc: Ngie Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 20:31:47 -0000 On Wed, May 3, 2017 at 1:38 PM, Alan Somers wrote: > On Wed, May 3, 2017 at 1:34 PM, Warner Losh wrote: >> On Wed, May 3, 2017 at 1:32 PM, Alan Somers wrote: >>> On Wed, May 3, 2017 at 12:16 PM, Ngie Cooper wrote: >>>> >>>>> On May 3, 2017, at 10:21, Alan Somers wrote: >>>>> >>>>> Author: asomers >>>>> Date: Wed May 3 17:21:01 2017 >>>>> New Revision: 317755 >>>>> URL: https://svnweb.freebsd.org/changeset/base/317755 >>>>> >>>>> Log: >>>>> Various Coverity fixes in ifconfig(8) >>>> >>>> ... >>>> >>>>> * Mark usage() as _Noreturn (1305806, 1305750) >>>> >>>> ... >>>> >>>>> -static void usage(void); >>>>> +static void usage(void) _Noreturn; >>>> >>>> Hi Alan, >>>> Please use __dead2 instead to be consistent with legacy use of similar gcc attributes. >>>> Thanks, >>>> -Ngie >>> >>> Why not use _Noreturn? It's standardized by C11, so tools understand >>> it better than __dead2. >> >> Tools that can't understand #define __dead2 _Noreturn aren't worth supporting. >> >> Warner > > Some tools don't expand preprocessor macros. Like my editor, for > example, which highlights _Noreturn as a keyword but not __dead2. "My editor is lame" isn't a good reason. However, % grep _Noreturn /usr/include/sys/cdefs.h #define _Noreturn __dead2 "Because it works, does the right thing and is standardized" is a much better reason. I hadn't checked to make sure that this was the case, but since it is, I think you did the right thing. Warner