From owner-freebsd-gnome@FreeBSD.ORG Sun Oct 5 12:51:18 2003 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4901516A4B3 for ; Sun, 5 Oct 2003 12:51:18 -0700 (PDT) Received: from ms-smtp-02.southeast.rr.com (ms-smtp-02.southeast.rr.com [24.93.67.83]) by mx1.FreeBSD.org (Postfix) with ESMTP id 97D1F43F85 for ; Sun, 5 Oct 2003 12:51:16 -0700 (PDT) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (rdu74-159-108.nc.rr.com [24.74.159.108])h95JlGkt029685; Sun, 5 Oct 2003 15:47:16 -0400 (EDT) Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) h95Jp81v005394; Sun, 5 Oct 2003 15:51:08 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Piero In-Reply-To: <20031005125233.M87991@poprostu.pl> References: <20031005125233.M87991@poprostu.pl> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-QQpFVeb1r9lttGrggb4t" Organization: MarcusCom, Inc. Message-Id: <1065383471.15483.24.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Sun, 05 Oct 2003 15:51:11 -0400 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.60 X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on creme-brulee.marcuscom.com cc: freebsd-gnome@freebsd.org Subject: Re: [new port] GNUGadu2 final shot? X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Oct 2003 19:51:18 -0000 --=-QQpFVeb1r9lttGrggb4t Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sun, 2003-10-05 at 09:02, Piero wrote: > HI, >=20 > So this is supposed to be the final version of the new port of GNU=20 > Gadu 2, GTK2 based development version of Polish IM client for=20 > Gadu-Gadu protocol very popular here. See: polish/gnugadu for gtk1.2=20 > old version. A few things here: * You should use ${ECHO_MSG} not ${ECHO_CMD} when displaying messages to the user * Never check for the existence of a directory (in fact, check into WANT_GNOME for some of what you're doing) * Your port installs libtool .la files. You should set USE_LIBTOOL, and borrow the configure patch from, say, gtk20 * Don't use WITH_ESOUND. Use WANT_GNOME, and check for ${HAVE_GNOME:Mesound}!=3D"" (checkout gstreamer-plugins for an example) * LIB_DEPENDS on ekg needs to appear right below the COMMENT in its own paragraph * pre-everything:: _usually_ comes first in the list of targets * Sort the plist lexicographically for installed items, and reverse lexicographically for @dirrms Joe >=20 > I am attaching two shars, one for the gnugadu2 and another for an=20 > optional dependency which would have its own PR (there are some=20 > issues with distfiles in libtlen, so I will wait till they are=20 > resolved). >=20 > Can you have a look at this? I want to file a PR, so I would like to=20 > avoid silly mistakes. Thanks, --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-QQpFVeb1r9lttGrggb4t Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3 (FreeBSD) iD8DBQA/gHYvb2iPiv4Uz4cRAtJXAKCl/MnjwbpjcFGlTRGrP7KXGiyO6gCgkWiB EdXx6elwNa7GgMAq8owjCD4= =6AqV -----END PGP SIGNATURE----- --=-QQpFVeb1r9lttGrggb4t--