From owner-cvs-ports@FreeBSD.ORG  Wed Jul  4 09:34:52 2007
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
X-Original-To: cvs-ports@FreeBSD.org
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 573EF16A46C; Wed,  4 Jul 2007 09:34:52 +0000 (UTC)
Date: Wed, 4 Jul 2007 09:34:52 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Rong-En Fan <rafan@FreeBSD.org>
Message-ID: <20070704093452.GA42272@FreeBSD.org>
References: <200707040506.l6456pxV090625@repoman.freebsd.org>
	<20070704090951.GB33211@FreeBSD.org>
	<20070704092227.GQ29573@svm.csie.ntu.edu.tw>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20070704092227.GQ29573@svm.csie.ntu.edu.tw>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net-p2p/verlihub Makefile distinfo
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2007 09:34:52 -0000

On Wed, Jul 04, 2007 at 05:22:27PM +0800, Rong-En Fan wrote:
> On Wed, Jul 04, 2007 at 09:09:51AM +0000, Alexey Dokuchaev wrote:
> > On Wed, Jul 04, 2007 at 05:06:51AM +0000, Rong-En Fan wrote:
> > > rafan       2007-07-04 05:06:51 UTC
> > > 
> > >   FreeBSD ports repository
> > > 
> > >   Modified files:
> > >     net-p2p/verlihub     Makefile distinfo 
> > >   Log:
> > >   - Set WRKSRC to remove ugly post-extract hack [1]
> > 
> > Does not seem right to me.  The error would appear on install stage
> > (more specifically, apply-slist one).  Please see my reply to Andrew's
> > mail.  Whenever you see a hack, it might be put there deliberately.
> 
> Okay, I see what happens when doing a tinderbox build.
> I will back out this one.

Thanks.

> 
> > I was also under impression that we normally give comitter a chance to
> > backout their changes themself, no?
> 
> I'm sorry about this. I just want to keep minimal changes 
> as I'm going to commit the plugins later. In that PR

Well, in this case the changes seem minimal to me.  Taking care of
verlihub.in would require *both* ${MV} and custom WRKSRC.

> it also has some patches for this port.

As you might guessed, I've seen the PR.  The problem I described is
taken care of, but personally I did not quite like their fix.

What would be the truly right thing to do here is to ask vendor to
correctly roll tarball next time.  :-)

./danfe