From nobody Wed Sep 24 15:04:29 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cX0W16QVJz6808f; Wed, 24 Sep 2025 15:04:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cX0W15rBMz3nPQ; Wed, 24 Sep 2025 15:04:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758726269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LyPVVN8OIPoIFXLax/+A6ElQn9w4H0w8GDnMNzBzj/U=; b=kiiKsjWGcYnpl8OkBtbhYmiGnWAuwhcVsJ3EJr+Mg5kjaE7ikzABz80j6xRV/yuofcsoBr 07btbUtW+SpjTwtLk/HlkBoyrpjvZ4jHp3DWZ1NvIarcyh6eqI+ihNmuKkXBH5/Cfp0Jlu YyV5dWl21xgm4+avwBFMsOZeeYWrFFefikf3FJAuj5y5OmSvTnHb7hygoIClXeUAqYHuGK P73/TngI16N4GvSBeOBY0/8Hoy8g1LqKgPXs3cwudAhPXBAmVCDPqbdr4eU2G6ELlDnlZq I5KQEh5ETFrKQ3gzvCMOSPdKsStK2hZl0mod9dNvH3G9xOLOX4rGz/mA3jBS2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758726269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LyPVVN8OIPoIFXLax/+A6ElQn9w4H0w8GDnMNzBzj/U=; b=vp031jg74WFSaC92UVexhnaKGIIUeWCuxWNOxcBfGtGOilUV81opHArejdyLcdmv+IYq+i mnLUVKzpVOMlyuZlV2xOgd4CkhVfFE67G788lEvSlGjsZuxatN+zfg2t9BBrU9ozjIp1Xi ACyJN/vHnQK2c1vofRXpgn5N4HA45q/RiQwvtTfx7a20gVEk+6j9wcifMcE0YyAY8vcHu6 Zg6DpPN+/v3bBXvlB5FdrXzDIIjWZzYhODvNqaqDjeJuDTbrzICmHRxHY9qHIMgNk1iQoH XYujA7SuBnMahkey5CVug2cuci/Z0fcRLl5eIe91tm9VMJigta5Kd8VdgK05NQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758726269; a=rsa-sha256; cv=none; b=BpbIw7v7hqFviF6ac7FtX21/BV+fqZdCjMHG4po+n1kquQ46T1Gw3IhOdjmyG4YYWwvKXt EpIHVr5K0jO1ekrlsDmUm04f1ufnXA72ibEfiR8JNzsx5rA365cWX0DaHgfF6sInBokdyZ 5qcD+n6JmpGXz90x6jHSWMKzhDIwJDCRUbhNA5tAXH9nLMWX4QsLu32+pH9I+acuUNl2NN 4YUYmsmnukfGFi3R4Y5R8+H0yVKw9SPNi0vPjL8QgM45FaYGOGhzvG6EavkKjTuS4SCnHo 0KAEUP0D5BFuKhhLUSBdgC0vUMqcpMdgQc2Y++9DOmS5DsfM84DTbAXNiQPJVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cX0W15Q8Yzd1Q; Wed, 24 Sep 2025 15:04:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58OF4Th9060370; Wed, 24 Sep 2025 15:04:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58OF4TLU060367; Wed, 24 Sep 2025 15:04:29 GMT (envelope-from git) Date: Wed, 24 Sep 2025 15:04:29 GMT Message-Id: <202509241504.58OF4TLU060367@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ahmad Khalifa Subject: git: 57d5a8feda3f - main - ng_tty: don't increment m_data List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 57d5a8feda3fd25a650eaab5998db13633d62d2d Auto-Submitted: auto-generated The branch main has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=57d5a8feda3fd25a650eaab5998db13633d62d2d commit 57d5a8feda3fd25a650eaab5998db13633d62d2d Author: Ahmad Khalifa AuthorDate: 2025-09-24 15:01:57 +0000 Commit: Ahmad Khalifa CommitDate: 2025-09-24 15:03:12 +0000 ng_tty: don't increment m_data Stop incrementing m_data so the callee can read the mbuf. MFC after: 3 days Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D52702 --- sys/netgraph/ng_tty.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index 6f8667c664bb..c7d8a1b64eac 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -485,9 +485,7 @@ ngt_rint(struct tty *tp, char c, int flags) } /* Add char to mbuf */ - *mtod(m, u_char *) = c; - m->m_data++; - m->m_len++; + *(u_char *)mtodo(m, m->m_len++) = c; m->m_pkthdr.len++; /* Ship off mbuf if it's time */